Remove unmaintained test module #7863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioAtSUSE
changed the title
- To avoid confusion. This module was used when the test suite relied on nested qemu machines. - The new systemd-testsuite modules can be found here: - lib/systemd_testsuite_test.pm - tests/systemd_testsuite/*.pm
SergioAtSUSE
force-pushed
the
remove_unmaintained_test_module
branch
from
7b856b4
to
1b29bd1
Compare
SergioAtSUSE
changed the title
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Jul 11, 2019
using get_required_var() as QA_HEAD_REPO is usually defined for SLES on medium level for all jobs, if it is missing, it is incorrect configuration at medium level. (That's why it's now required in tests/virt_autotest/pvusb_run.pm). Use it also in tests/kernel_performance/install_qatestset.pm, instead of custom QA_REPO variable. NOTE: not using in * virt_autotest/install_package.pm add_qa_head_repo() cannot be used on lpar_cmd() + it'd benefit to reduce duplicity of commands used lpar vs. other arch: there should be some wrapper to remove duplicity, but there are a few subtle differences which needs to be kept. According to @alice-suse 'zypper rr' needs to be kept, or it will cause trouble in second triggering, especially s390, which reuses host. * tests/console/systemd_testsuite.pm According to @SergioAtSUSE systemd testsuite uses different QA_HEAD_REPO than the one from QAM. And this module is going to be removed/replaced anyway: https://progress.opensuse.org/issues/45158 os-autoinst#7863
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Jul 12, 2019
using get_required_var() as QA_HEAD_REPO and QA_WEB_REPO are usually defined for SLES on medium level for all jobs, if it is missing, it is incorrect configuration at medium level. (That's why it's now required in tests/virt_autotest/pvusb_run.pm). tests/qa_automation/prepare_qa_repo.pm completely replaced by add_qa_head_repo() and add_qa_web_repo(). Use add_qa_head_repo() also in tests/kernel_performance/install_qatestset.pm, instead of custom QA_REPO variable. NOTE: not using add_qa_head_repo() in: * virt_autotest/install_package.pm add_qa_head_repo() cannot be used on lpar_cmd() + it'd benefit to reduce duplicity of commands used lpar vs. other arch: there should be some wrapper to remove duplicity, but there are a few subtle differences which needs to be kept. According to @alice-suse 'zypper rr' needs to be kept, or it will cause trouble in second triggering, especially s390, which reuses host. * tests/console/systemd_testsuite.pm According to @SergioAtSUSE systemd testsuite uses different QA_HEAD_REPO than the one from QAM. And this module is going to be removed/replaced anyway: https://progress.opensuse.org/issues/45158 os-autoinst#7863
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Jul 12, 2019
using get_required_var() as QA_HEAD_REPO and QA_WEB_REPO are usually defined for SLES on medium level for all jobs, if it is missing, it is incorrect configuration at medium level. (That's why it's now required in tests/virt_autotest/pvusb_run.pm). tests/qa_automation/prepare_qa_repo.pm completely replaced by add_qa_head_repo() and add_qa_web_repo(). Use add_qa_head_repo() also in tests/kernel_performance/install_qatestset.pm, instead of custom QA_REPO variable. NOTE: not using add_qa_head_repo() in: * virt_autotest/install_package.pm add_qa_head_repo() cannot be used on lpar_cmd() + it'd benefit to reduce duplicity of commands used lpar vs. other arch: there should be some wrapper to remove duplicity, but there are a few subtle differences which needs to be kept. According to @alice-suse 'zypper rr' needs to be kept, or it will cause trouble in second triggering, especially s390, which reuses host. * tests/console/systemd_testsuite.pm According to @SergioAtSUSE systemd testsuite uses different QA_HEAD_REPO than the one from QAM. And this module is going to be removed/replaced anyway: https://progress.opensuse.org/issues/45158 os-autoinst#7863
pevik
added a commit
to pevik/os-autoinst-distri-opensuse
that referenced
this pull request
Jul 12, 2019
using get_required_var() as QA_HEAD_REPO and QA_WEB_REPO are usually defined for SLES on medium level for all jobs, if it is missing, it is incorrect configuration at medium level. (That's why it's now required in tests/virt_autotest/pvusb_run.pm). tests/qa_automation/prepare_qa_repo.pm completely replaced by add_qa_head_repo() and add_qa_web_repo(). Use add_qa_head_repo() also in tests/kernel_performance/install_qatestset.pm, instead of custom QA_REPO variable. NOTE: not using add_qa_head_repo() in: * virt_autotest/install_package.pm add_qa_head_repo() cannot be used on lpar_cmd() + it'd benefit to reduce duplicity of commands used lpar vs. other arch: there should be some wrapper to remove duplicity, but there are a few subtle differences which needs to be kept. According to @alice-suse 'zypper rr' needs to be kept, or it will cause trouble in second triggering, especially s390, which reuses host. * tests/console/systemd_testsuite.pm According to @SergioAtSUSE systemd testsuite uses different QA_HEAD_REPO than the one from QAM. And this module is going to be removed/replaced anyway: https://progress.opensuse.org/issues/45158 os-autoinst#7863
coolgw
pushed a commit
to coolgw/os-autoinst-distri-opensuse
that referenced
this pull request
Aug 19, 2019
using get_required_var() as QA_HEAD_REPO and QA_WEB_REPO are usually defined for SLES on medium level for all jobs, if it is missing, it is incorrect configuration at medium level. (That's why it's now required in tests/virt_autotest/pvusb_run.pm). tests/qa_automation/prepare_qa_repo.pm completely replaced by add_qa_head_repo() and add_qa_web_repo(). Use add_qa_head_repo() also in tests/kernel_performance/install_qatestset.pm, instead of custom QA_REPO variable. NOTE: not using add_qa_head_repo() in: * virt_autotest/install_package.pm add_qa_head_repo() cannot be used on lpar_cmd() + it'd benefit to reduce duplicity of commands used lpar vs. other arch: there should be some wrapper to remove duplicity, but there are a few subtle differences which needs to be kept. According to @alice-suse 'zypper rr' needs to be kept, or it will cause trouble in second triggering, especially s390, which reuses host. * tests/console/systemd_testsuite.pm According to @SergioAtSUSE systemd testsuite uses different QA_HEAD_REPO than the one from QAM. And this module is going to be removed/replaced anyway: https://progress.opensuse.org/issues/45158 os-autoinst#7863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nested qemu machines.
Related ticket: https://progress.opensuse.org/issues/45158
Verification run: http://openqa.slindomansilla-vm.qa.suse.de/tests/1497