Firefox_nss: Revert unnecessary x11utils::turn_off_gnome_screensaver call

[jouyingbin]

Firefox_nss calls x11utils::turn_off_gnome_screensaver is a simple
script_run 'gsettings set org.gnome.desktop.session idle-delay 0';

1. In order to avoid no terminal is shown the string which is just typed "into the void"
   of the desktop session. Therefore there is also never an output on the serial port.
2. This patch can also fixed the side effect error about case running after firefox_nss.

Error run: https://openqa.suse.de/tests/3022911#step/firefox_nss/4

• Related ticket:
  https://progress.opensuse.org/issues/53978
  https://progress.opensuse.org/issues/53651
• Needles: NA
• Verification run:
  (firefox_nss -> seahorse_sshkey) http://10.163.2.52/tests/297
  (firefox_nss -> hexchat_ssl) http://10.163.2.52/tests/298

[lilyeyes]

LGTM.

[ghost]

The change does not explain why turn_off_gnome_screensaver make following select_console failed. If we want to dive deeper we should check the code which implement turn_off_gnome_screensaver in x11utils. But as a work around it is acceptable to simply remove it from the code.

[jouyingbin]

The change does not explain why turn_off_gnome_screensaver make following select_console failed. If we want to dive deeper we should check the code which implement turn_off_gnome_screensaver in x11utils. But as a work around it is acceptable to simply remove it from the code.

Firefox_nss calls x11utils::turn_off_gnome_screensaver is a simple script_run 'gsettings set org.gnome.desktop.session idle-delay 0';

We can either add select_console 'root-console' or xterm to type the command script_run 'gsettings set org.gnome.desktop.session idle-delay 0'; e.g., add x11_start_program('xterm') and then run turn_off_gnome_screensaver if check_var('DESKTOP', 'gnome'), I think it can also fix the problem too.

Currently, I don't see the reason that we need to really turn off the screen saver, so I plan to revert the turn_off_gnome_screensaver function call.

Thanks.

[ghost]

LGTM

[lemon-suse]

LGTM.