Add test scenario to verify AY installation while using disk as MD member #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit extracts the part of the test_setup function related to autoyast initialization to the separate function and makes the function utilitarian by placing it in lib/autoyast.pm
The commit adds the function to have ability to find all the nodes in xml file by xpath and returns them as an array. That allows to manipulate with the found nodes in the manner that is required for the certain test (e.g. get values from the nodes, count them etc.)
rwx788
reviewed
Jul 17, 2019
| </partition> | ||
| <partition> | ||
| <create config:type="boolean">true</create> | ||
| <mount>/boot</mount> |
There was a problem hiding this comment.
Shall we implement feature to inject values from test_data structure, similarly to what we've done with vars.json?
There was a problem hiding this comment.
I never thought about that, but it might be great to have the feature I guess, as it will allow to change some data just in one place, rather then check all the places where it is used.
But, I guess it should be done in scope of another task?
There was a problem hiding this comment.
Sure. Just wanted to hear your opinion. I will create a ticket for that.
rwx788
reviewed
Jul 17, 2019
The commit adds all the required perl modules and the yaml schedule to test autoyast installation while using disk as MD member.
OleksandrOrlov
force-pushed
the
42731_disk_as_md_member
branch
from
fdc4b25
to
b9c63ef
Compare
|
Please, enable the test suite for the relevant distributions and versions. |
|
Enabled for YaST Job group, Sle15, 64bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds all the required perl modules and the yaml schedule to test autoyast installation while using disk as MD member.
After being merged, the PR requires the following configuration to be updated on openQA:
Test Suites:
autoyast_disk_as_md_memberJob Groups->SLE15->YaST->new test:
autoyast_disk_as_md_member