Fix sporadic issues with key presses for yast2 tftf and samba test modules #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 17, 2019 13:41
In os-autoinst#7802 we have removed `assert_screen` call after we open firewall details dialog. After that we open logs dialog, but press key to early as previous dialog is still open. With this PR, we assert that we got to the original screen before the key press. See [poo#53972](https://progress.opensuse.org/issues/53972).
rwx788
changed the title
|
I think we are not handling FW port properly. Most likely the above needle is just incorrect. |
Nice catch, but I've recognized that I have outdated set of needles, on osd we have another needle matching: https://openqa.suse.de/tests/3078000#step/yast2_tftp/9 I will check if we should increase matching level for those to detect checkbox state properly. |
|
I've cleaned-up needles, so last VR doesn't have that problem. Synchronization problem is also resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7802 we have removed
assert_screencall after we open firewalldetails dialog. After that we open logs dialog, but press key to early
as previous dialog is still open.
With this PR, we assert that we got to the original screen before the
key press.
For samba module we have
wait_screen_changewrapper which is not solving the issue with key presses sync. Extra needle was created using openQA webui.See poo#53972.
Verification runs