Fix PR#7951 #8020
Fix PR#7951 #8020
Conversation
|
Verification: https://openqa.suse.de/tests//3131588 |
Now only using root-ssh where it should exist
DrMullings
force-pushed
the
select_console
branch
from
d9fa708
to
2a4ce0d
Compare
|
Waiting for travis |
| @@ -682,7 +682,7 @@ sub activate_console { | |||
| assert_screen "inst-console"; | |||
| } | |||
| } | |||
| elsif ($console =~ m/root-console$/ && is_remote_backend) { | |||
| elsif ($console =~ m/root-console$/ && get_var('BACKEND' =~ /ikvm|ipmi|spvm/)) { | |||
There was a problem hiding this comment.
This introduced a regression (found by @czerw, he's creating PR which fixes it)
|
@DrMullings we tried to replace the explicit checks for the BACKEND variable with methods with an easy to understand name. When |
Good :). Yesterday, I was thinking to introduce something like this as well. |
|
@okurz, we also didn't came up with a good idea for the name, so we left the backends. What do you think about |
|
"root_console_is_ssh()" sounds like an arbitrary choice in the test code itself, not describing the infrastructure. So to me it seems we are going back and forth with changes because some people still don't understand what's going on. The backends and especially their handling differ in test code but all of this can be changed where it makes sense. If a console behaves different on a certain backend but it shouldn't, change it! :) |
|
@okurz, the use of SSH for those specific backends is an arbitrary choice, that's the difficult part of chosing a name. So, we left the backend then. |
Now only using root-ssh where it should exist