Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application_starts_on_login: Fix auto-save-session search #8051

Merged
merged 1 commit into from Jul 31, 2019

Conversation

ggardet
Copy link
Collaborator

@ggardet ggardet commented Jul 29, 2019

On aarch64, first occurence is pre-selected, so if you type enter key at the end of the search string, you open the setting window. On x86, it is not pre-selected, but removing the enter key does not change anything.
Verification runs:

@ggardet ggardet changed the title [WIP] Fix auto-save-session search application_starts_on_login: Fix auto-save-session search Jul 30, 2019
@okurz
Copy link
Member

okurz commented Jul 31, 2019

@foursixnine I don't understand why I can not simply merge this PR even after approval.

EDIT: I understood this is because of the additional restriction which I assume you put in to require a branch to be "up-to-date" but I am afraid this is nearly impossible for us to achieve. I created https://progress.opensuse.org/issues/54926 to discuss this.

@okurz
Copy link
Member

okurz commented Aug 1, 2019

I merged a revert for now as our assumption was wrong that the newline does not have an effect. @ggardet I hope you feel encouraged to try again with a different approach :)

@jlausuch
Copy link
Contributor

jlausuch commented Aug 1, 2019

@ggardet maybe use is_opensuse function from version_utils to differentiate, as this change breaks SLE tests.

@okurz
Copy link
Member

okurz commented Aug 1, 2019

I don't see why there should be a difference in behaviour of the gnome application comparing openSUSE or SLE unless this was a conscious decision or a bug which should be handled properly and not just worked around

@ggardet
Copy link
Collaborator Author

ggardet commented Aug 14, 2019

I don't see why there should be a difference in behaviour of the gnome application comparing openSUSE or SLE unless this was a conscious decision or a bug which should be handled properly and not just worked around

I used the changing-scheme-popup case and it is now OK by just adding needles:
https://openqa.opensuse.org/tests/1007099#step/application_starts_on_login/104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants