[ooffice] Close "Tip of the day" dialog in desktopapps-documentation-x11 #8188
Conversation
StefanBruens
force-pushed
the
ooffice_tip_of_the_day_2
branch
5 times, most recently
from
eedd5bf
to
9dc3a81
Compare
StefanBruens
changed the title
|
@okurz - ready to go ... |
StefanBruens
force-pushed
the
ooffice_tip_of_the_day_2
branch
from
9dc3a81
to
edbe9ae
Compare
| @@ -127,6 +127,20 @@ sub run { | |||
| type_string "calc"; #open calc | |||
| assert_and_click 'overview-office-calc'; | |||
| assert_screen 'test-oocalc-1'; | |||
| if (!match_has_tag('ooffice-tip-of-the-day')) { | |||
| # Sometimes the dialog appears after a short delay | |||
There was a problem hiding this comment.
I don't understand why that should be needed. assert_screen by default has a timeout of 30s meaning in line L129 we already wait for 30s anyway. If this is not enough, simply add a timeout value there?
There was a problem hiding this comment.
'test-oocalc-1' are needles with and without the tip dialog. First the program is shown, then the dialog appears - but in approximately 19/20 cases, this is the same frame.
| # make sure the dialog has really closed before quiting with "ctrl-q" | ||
| wait_screen_change { send_key "alt-o" }; | ||
| assert_screen 'test-oocalc-1'; | ||
| } |
There was a problem hiding this comment.
Looks like this loop can be replaced by send_key_until_needlematch 'test-oocalc-1', 'alt-o';
There was a problem hiding this comment.
but its 'send_key_while_needlematch` ...
There was a problem hiding this comment.
yes, this is why suggested to look for test-oocalc-1 as the final picture assuming that the needle test-oocalc-1 would only match if the dialog is not shown. If it is not the case we could create proper new needles and delete older ambiguous one.
There was a problem hiding this comment.
ah, sorry. Read your comment in before that the needle is ambiguous. Still, what do you think about making that unambiguous and deleting all needles of tag test-oocalc-1 with the dialog shown?
There was a problem hiding this comment.
Depending on how many screen check iterations we would usually encounter it might make sense to have a short "sleep" period, e.g. sleep .1 after each step, WDYT?
|
ok, fine. Let's keep as is. You need some changes for tidy though: https://travis-ci.org/os-autoinst/os-autoinst-distri-opensuse/jobs/573003146#L446 |
StefanBruens
force-pushed
the
ooffice_tip_of_the_day_2
branch
from
edbe9ae
to
4dbfd07
Compare
|
@okurz - tidy cleanup done |
LibreOffice 6.3 shows a "Tip of the day" dialog. Unselect the "Show tips on startup" checkbox and close it. Related ticket: https://progress.opensuse.org/issues/54722 Verification run: https://openqa.opensuse.org/tests/1020089 Verification run: https://openqa.opensuse.org/tests/1020095
StefanBruens
force-pushed
the
ooffice_tip_of_the_day_2
branch
from
4dbfd07
to
6fa1a99
Compare
|
In any case, I think it's save to merge |
LibreOffice 6.3 shows a "Tip of the day" dialog. Unselect the
"Show tips on startup" checkbox and close it.
Related ticket: https://progress.opensuse.org/issues/54722
Verification run: https://openqa.opensuse.org/tests/1009986
Verification run: https://openqa.opensuse.org/tests/1020089
Verification run: https://openqa.opensuse.org/tests/1020095