Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document methods in lib/opensusebasetest.pm #8313

Merged
merged 4 commits into from Aug 30, 2019

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Aug 28, 2019

@asdil12 asdil12 marked this pull request as ready for review August 28, 2019 13:27
@asdil12 asdil12 force-pushed the nice_docs branch 4 times, most recently from a89aba0 to 3622ab0 Compare August 30, 2019 07:48
=cut
sub pkcon_quit {
script_run("systemctl mask packagekit; systemctl stop packagekit; while pgrep packagekitd; do sleep 1; done");
}

=head2 addon_decline_license

addon_decline_license();

TODO someone should document this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some TODOs here, are they intended or did you missed them?

@@ -730,6 +846,8 @@ sub addon_decline_license {

=head2 addon_license

addon_license($addon);

TODO someone should document this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another TODO

@SergioAtSUSE SergioAtSUSE merged commit 8d757ac into os-autoinst:master Aug 30, 2019
@SergioAtSUSE
Copy link
Member

Clarified in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants