Fix false positive in validate_raid #8438
Conversation
|
Could you provide VRs on aarch64 as well, please? |
jknphy
force-pushed
the
fix_validate_raid
branch
5 times, most recently
from
9de664f
to
5a29985
Compare
jknphy
force-pushed
the
fix_validate_raid
branch
from
5a29985
to
e60dbd8
Compare
| $btrfs, $swap, | ||
| ); | ||
| if (is_sle('<=15-SP1') || get_var('STAGING') || | ||
| is_leap() || (is_tumbleweed() && check_var('FLAVOR', 'NET'))) { |
There was a problem hiding this comment.
I am wondering why NET flavor should be handled separately?
There was a problem hiding this comment.
DVD TW have both arrays in the same raid level while NET TW has this 'special' RAID0 for swap.
There was a problem hiding this comment.
Ok, I see it in openQA. But it looks like a bug to me. DVD and NET should have the same behavior, no?
There was a problem hiding this comment.
Now I have checked better, I can see that this is an artificial difference that we have created, we use different module to do the raid, an OOP module installation/partitioning/raid_gpt and a legacy one installation/partitioning_raid. I would leave that out-of-scope of this PR and I will share with the team to fix in the future. Ticket created: https://progress.opensuse.org/issues/56870
jknphy
changed the title
|
I'm afraid this failure https://openqa.opensuse.org/tests/1032687#step/validate_raid/9 is related to this change? |
Thanks. I missed that one: #8445 |
Fix false positive only in x86_64 when validating partitioning and raid in product different from SLE-12.
Fix false positive for aarch validating raid (only partitioning was validated)