Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation for textmode on spvm backend #8506

Merged
merged 1 commit into from Sep 23, 2019
Merged

Fix installation for textmode on spvm backend #8506

merged 1 commit into from Sep 23, 2019

Conversation

czerw
Copy link
Contributor

@czerw czerw commented Sep 23, 2019 •
edited

Fix poo#56924: Installation was not started in textmode.
Extend VIDEOMODE condition with textmode.

@czerw
Copy link
Contributor Author

czerw commented Sep 23, 2019

@Soulofdestiny @rwx788 could you please have a look?

@SergioAtSUSE
Copy link
Member

Maybe I am missing something obvious, but does this means that it will always try to do perform an SSH installation?

We also have scenarios that performs VNC installation: https://openqa.suse.de/tests/3321990#step/welcome/1

@czerw
Copy link
Contributor Author

czerw commented Sep 23, 2019

Maybe I am missing something obvious, but does this means that it will always try to do perform an SSH installation?

We also have scenarios that performs VNC installation: https://openqa.suse.de/tests/3321990#step/welcome/1

It was always started without condition. It was recently changed in #8419, but it is not obvious if it was fixing something specific. Just limiting without reason.

But I can extend condition instead of removal.

@czerw czerw force-pushed the poo#56924 branch 2 times, most recently from 6751bf9 to 8dc36a7 Compare September 23, 2019 13:50
@czerw
Fix installation for textmode on spvm backend
96faa9d 
Fix poo#56924: Installation was not started in textmode.
Extend VIDEOMODE condition with textmode.
@czerw
Copy link
Contributor Author

czerw commented Sep 23, 2019

@SergioAtSUSE Extended condition with text mode, did verification for vnc and text mode install, but couldn't find any job with ssh-x for spvm installation

@czerw
Copy link
Contributor Author

czerw commented Sep 23, 2019

@SergioAtSUSE Extended condition with text mode, did verification for vnc and text mode install, but couldn't find any job with ssh-x for spvm installation

Ok, finally found ssh-x verification is https://openqa.suse.de/tests/3394033

SergioAtSUSE
SergioAtSUSE approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@SergioAtSUSE SergioAtSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@SergioAtSUSE SergioAtSUSE merged commit f99e677 into os-autoinst:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioAtSUSE SergioAtSUSE SergioAtSUSE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@czerw @SergioAtSUSE