Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypt disk on spvm to test partitions activation #8657

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Encrypt disk on spvm to test partitions activation #8657

merged 2 commits into from
Oct 14, 2019

Conversation

rwx788
Copy link
Member

@rwx788 rwx788 commented Oct 11, 2019 •
edited
Loading

@rwx788 rwx788 added the WIP Work in progress label Oct 11, 2019
@rwx788 rwx788 force-pushed the spvm branch 6 times, most recently from b1db4e3 to 942a1fb Compare October 14, 2019 09:23
@rwx788 rwx788 removed the WIP Work in progress label Oct 14, 2019
@rwx788 rwx788 added the WIP Work in progress label Oct 14, 2019
jknphy
jknphy reviewed Oct 14, 2019
View reviewed changes
lib/bootloader_setup.pm Outdated

create_encrypted_part($disk);

Creates gpt partition tbale on a given disk and creates encrypted partition on it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/tbale/table

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rwx788 rwx788 removed the WIP Work in progress label Oct 14, 2019
@rwx788
Copy link
Member Author

rwx788 commented Oct 14, 2019

I had minor mistake in the schedule, will wait for VR before merging. Thanks for the review!

@rwx788 rwx788 removed the request for review from OleksandrOrlov October 14, 2019 11:31
@rwx788 rwx788 merged commit 823a0c8 into os-autoinst:master Oct 14, 2019
@rwx788 rwx788 deleted the spvm branch May 18, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rwx788 @jknphy