boot_into_snapshot moved to boot_into_snapshot #8673
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Oct 16, 2019
The boot_into_snapshot has separated from grub_test. This mean that jobs that used the 'start bootloader from read-only snapshot' make use of boot_into_snapshot. Apparently we could get rid of the BOOT_TO_SNAPSHOT variable as well.
lib/main_common.pm has been updated 1d3de4d |
rwx788
reviewed
Oct 30, 2019
|
|
||
| sub run { | ||
| my ($self) = @_; | ||
| stop_grub_timeout; |
There was a problem hiding this comment.
We have more steps in grub_test which we should have here. Like entering password if boot partition is encrypted and asserting that grub is shown. And some special steps for xen, for which we don't have VR.
TBH, now I'm not sure if this separation will make out lives any better....
|
So i am going to close this one as https://progress.opensuse.org/issues/53801 was rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boot_into_snapshot has separated from grub_test. This mean that
jobs that used the 'start bootloader from read-only snapshot' make
use of boot_into_snapshot. Apparently we could get rid of the BOOT_TO_SNAPSHOT
variable as well.
boot_to_snapshot
opensuse-Tumbleweed-DVD.x86_64
sle-12-SP5-Server-DVD.x86_64
using grub_test
sle-12-SP5-Server-DVD.x86_64