Add missing documentation for x11utils #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdil12
requested changes
Oct 14, 2019
lib/x11utils.pm
Outdated
|
|
||
| ensure_fullscreen($tag); | ||
|
|
||
| tag can contain a needle name and is optional, it defaults to yast2-windowborder |
There was a problem hiding this comment.
Suggested change
| tag can contain a needle name and is optional, it defaults to yast2-windowborder | |
| C<$tag> can contain a needle name and is optional, it defaults to yast2-windowborder |
lib/x11utils.pm
Outdated
|
|
||
| handle_relogin(); | ||
|
|
||
| First logs out and the log in via C<handle_logout> and C<handle_login> |
There was a problem hiding this comment.
Suggested change
| First logs out and the log in via C<handle_logout> and C<handle_login> | |
| First logs out and the log in via C<handle_logout()> and C<handle_login()> |
lib/x11utils.pm
Outdated
|
|
||
| select_user_gnome($myuser); | ||
|
|
||
| Handle the case when user is not selected in login screen, on gnome |
There was a problem hiding this comment.
Suggested change
| Handle the case when user is not selected in login screen, on gnome | |
| Handle the case when user is not selected in login screen, on gnome. | |
| C<$myuser> specifies the username to switch to. | |
| If not set, it will default to C<$username>. |
lib/x11utils.pm
Outdated
| # Handle the case when user is not selected, on gnome | ||
| =head2 select_user_gnome | ||
|
|
||
| select_user_gnome($myuser); |
There was a problem hiding this comment.
Suggested change
| select_user_gnome($myuser); | |
| select_user_gnome([$myuser]); |
Now every function is documented
DrMullings
force-pushed
the
documentation
branch
from
59e2e2a
to
7e695ba
Compare
|
Updated with suggestions |
SergioAtSUSE
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
@asdil12, can you check for missing leading spaces / blank lines?
asdil12
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now every function is documented