Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wicked: add sleep after hotplug-in a device #8766

Merged
merged 1 commit into from Oct 25, 2019
Merged

Wicked: add sleep after hotplug-in a device #8766

merged 1 commit into from Oct 25, 2019

Conversation

jlausuch
Copy link
Contributor

@jlausuch
Copy link
Contributor Author

@dzedro can you please test this change in QAM job? I can't reproduce the failure in my local instance.

@asmorodskyi
Copy link
Member

LGTM but I wouldn't merge it without QAM test run so we actually see that this sleep doing something

@dzedro
Copy link
Contributor

dzedro commented Oct 24, 2019

@dzedro can you please test this change in QAM job? I can't reproduce the failure in my local instance.

Tried but mine mm is broken.

@jlausuch
Copy link
Contributor Author

Tried but mine mm is broken.

you can trigger it directly in openqa
https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc#triggering-tests-based-on-an-any-remote-git-refspec-or-open-github-pull-request

@dzedro
Copy link
Contributor

dzedro commented Oct 24, 2019

Tried but mine mm is broken.

you can trigger it directly in openqa
https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc#triggering-tests-based-on-an-any-remote-git-refspec-or-open-github-pull-request

Multimachine ? since when ?

@asmorodskyi
Copy link
Member

Tried but mine mm is broken.

you can trigger it directly in openqa
https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc#triggering-tests-based-on-an-any-remote-git-refspec-or-open-github-pull-request

Multimachine ? since when ?

hard to tell since when but I can ensure you that yes you can clone MM jobs in osd and they will properly work . In case of wicked just make sure that you cloning SUT job

@coolo
Copy link
Contributor

coolo commented Oct 24, 2019

make sure you clone the job that has the PARALLEL_WITH setting, so that clone-job knows

@dzedro
Copy link
Contributor

dzedro commented Oct 24, 2019

Tried but mine mm is broken.

you can trigger it directly in openqa
https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc#triggering-tests-based-on-an-any-remote-git-refspec-or-open-github-pull-request

Multimachine ? since when ?

hard to tell since when but I can ensure you that yes you can clone MM jobs in osd and they will properly work . In case of wicked just make sure that you cloning SUT job

Please show me, because it doesn't work for me.

# openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8766 https://openqa.suse.de/tests/3517471
Cloning dependencies of sle-15-Server-DVD-Updates-x86_64-Build20191024-1-qam_wicked_advanced_sut@64bit
Created job #3518308: sle-15-Server-DVD-Updates-x86_64-Build20191024-1-qam_wicked_advanced_ref@64bit -> https://openqa.suse.de/t3518308
Created job #3518309: sle-15-Server-DVD-Updates-x86_64-Build20191024-1-qam_wicked_advanced_sut@64bit -> https://openqa.suse.de/t3518309

@rwx788
Copy link
Member

rwx788 commented Oct 24, 2019 •
edited

Tried but mine mm is broken.

you can trigger it directly in openqa
https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc#triggering-tests-based-on-an-any-remote-git-refspec-or-open-github-pull-request

Multimachine ? since when ?

hard to tell since when but I can ensure you that yes you can clone MM jobs in osd and they will properly work . In case of wicked just make sure that you cloning SUT job

Please show me, because it doesn't work for me.

# openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8766 https://openqa.suse.de/tests/3517471
Cloning dependencies of sle-15-Server-DVD-Updates-x86_64-Build20191024-1-qam_wicked_advanced_sut@64bit
Created job #3518308: sle-15-Server-DVD-Updates-x86_64-Build20191024-1-qam_wicked_advanced_ref@64bit -> https://openqa.suse.de/t3518308
Created job #3518309: sle-15-Server-DVD-Updates-x86_64-Build20191024-1-qam_wicked_advanced_sut@64bit -> https://openqa.suse.de/t3518309

I can state only thing I faced myself, that PR changes are applied only to the cloned job and other parallel jobs use master branch of the upstream repo.

@okurz has kindly shared flag with us --parental-inheritance and it's recent.

@jlausuch
Copy link
Contributor Author

I can state only thing I faced myself, that PR changes are applied only to the cloned job and other parallel jobs use master branch of the upstream repo.

In this case it's fine, as we are cloning the job which contains the change.

@coolo
Copy link
Contributor

coolo commented Oct 24, 2019

Ah, right - you need some more tricks.

This is what I did last time:

coolo@openqa:~> dry_run=echo openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8653 https://openqa.suse.de/tests/3468890openqa-clone-job --skip-chained-deps --within-instance https://openqa.suse.de 3468890 _GROUP=0 TEST=qam-wicked_basic_sut@asmorodskyi/os-autoinst-distri-opensuse#fix_for_fix BUILD=asmorodskyi/os-autoinst-distri-opensuse#8653 CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#fix_for_fix PRODUCTDIR=os-autoinst-distri-opensuse/products/sle NEEDLES_DIR=/var/lib/openqa/cache/openqa.suse.de/tests/sle/products/sle/needles

-> editing the output to include --parental-inheritance

openqa-clone-job --parental-inheritance --skip-chained-deps --within-instance https://openqa.suse.de 3468890 _GROUP=0 TEST=qam-wicked_basic_sut@asmorodskyi/os-autoinst-distri-opensuse#fix_for_fix BUILD=asmorodskyi/os-autoinst-distri-opensuse#8653 CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#fix_for_fix PRODUCTDIR=os-autoinst-distri-opensuse/products/sle NEEDLES_DIR=/var/lib/openqa/cache/openqa.suse.de/tests/sle/products/sle/needles

@dzedro
Copy link
Contributor

dzedro commented Oct 24, 2019

Ah, right - you need some more tricks.

This is what I did last time:

coolo@openqa:~> dry_run=echo openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8653 https://openqa.suse.de/tests/3468890openqa-clone-job --skip-chained-deps --within-instance https://openqa.suse.de 3468890 _GROUP=0 TEST=qam-wicked_basic_sut@asmorodskyi/os-autoinst-distri-opensuse#fix_for_fix BUILD=asmorodskyi/os-autoinst-distri-opensuse#8653 CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#fix_for_fix PRODUCTDIR=os-autoinst-distri-opensuse/products/sle NEEDLES_DIR=/var/lib/openqa/cache/openqa.suse.de/tests/sle/products/sle/needles

-> editing the output to include --parental-inheritance

openqa-clone-job --parental-inheritance --skip-chained-deps --within-instance https://openqa.suse.de 3468890 _GROUP=0 TEST=qam-wicked_basic_sut@asmorodskyi/os-autoinst-distri-opensuse#fix_for_fix BUILD=asmorodskyi/os-autoinst-distri-opensuse#8653 CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#fix_for_fix PRODUCTDIR=os-autoinst-distri-opensuse/products/sle NEEDLES_DIR=/var/lib/openqa/cache/openqa.suse.de/tests/sle/products/sle/needles

secret tricks as always 😆

@jlausuch
Copy link
Contributor Author

jlausuch commented Oct 24, 2019 •
edited

Ah, right - you need some more tricks.

This is what I did last time:

coolo@openqa:~> dry_run=echo openqa-clone-custom-git-refspec https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/8653 https://openqa.suse.de/tests/3468890openqa-clone-job --skip-chained-deps --within-instance https://openqa.suse.de 3468890 _GROUP=0 TEST=qam-wicked_basic_sut@asmorodskyi/os-autoinst-distri-opensuse#fix_for_fix BUILD=asmorodskyi/os-autoinst-distri-opensuse#8653 CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#fix_for_fix PRODUCTDIR=os-autoinst-distri-opensuse/products/sle NEEDLES_DIR=/var/lib/openqa/cache/openqa.suse.de/tests/sle/products/sle/needles

-> editing the output to include --parental-inheritance

openqa-clone-job --parental-inheritance --skip-chained-deps --within-instance https://openqa.suse.de 3468890 _GROUP=0 TEST=qam-wicked_basic_sut@asmorodskyi/os-autoinst-distri-opensuse#fix_for_fix BUILD=asmorodskyi/os-autoinst-distri-opensuse#8653 CASEDIR=https://github.com/asmorodskyi/os-autoinst-distri-opensuse.git#fix_for_fix PRODUCTDIR=os-autoinst-distri-opensuse/products/sle NEEDLES_DIR=/var/lib/openqa/cache/openqa.suse.de/tests/sle/products/sle/needles

When I try this I end up in having same test in both jobs (sut, sut):
https://openqa.suse.de/tests/3526018#dependencies

but whithout --parental-inheritance it works as it should (sut, ref):
https://openqa.suse.de/tests/3526021#dependencies

but then t20 is not executed in sut, but it's executed in ref... not sure why..

@jlausuch
Wicked: add sleep after hotplug-in a device
cf537ea 
After hotplug-ing the device sometimes we are too
fast on running command which verifying it's state.
Especially in osd where things could be really slow
@jlausuch
Copy link
Contributor Author

I managed to have a VR cloning failed job in qam: https://openqa.suse.de/tests/3529238

Let me know if that's sufficient or you would like to test it yourself.

@dzedro dzedro merged commit 050000a into os-autoinst:master Oct 25, 2019
@jlausuch jlausuch deleted the wicked_hotplug_sleep branch May 19, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorodskyi asmorodskyi Awaiting requested review from asmorodskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@jlausuch @asmorodskyi @dzedro @coolo @rwx788