add "yast_ftp_server" to support SLE12sp5 #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foursixnine @mimi1vx Could you please review it? |
foursixnine
reviewed
Nov 13, 2019
tests/yast2_cmd/yast_ftp_server.pm
Outdated
| @@ -110,7 +110,7 @@ sub run { | |||
| if (is_sle('15+')) { | |||
| assert_script_run 'yast ftp-server startup socket'; | |||
| } | |||
| if (is_sle('<=12-sp4')) { | |||
| if (is_sle('<15')) { | |||
There was a problem hiding this comment.
It is fine, but just to be explicit, I'd personally use:
Suggested change
| if (is_sle('<15')) { | |
| if (is_sle('<=12-sp5')) { |
tests/yast2_cmd/yast_ftp_server.pm
Outdated
| @@ -153,7 +153,7 @@ sub run { | |||
| if (is_sle('15+')) { | |||
| assert_script_run 'yast ftp-server startup socket'; | |||
| } | |||
| if (is_sle('<=12-sp4')) { | |||
| if (is_sle('<15')) { | |||
foursixnine
approved these changes
Nov 13, 2019
skliu
force-pushed
the
yast_ftp_server
branch
from
a2f50b9
to
d9565aa
Compare
skliu
force-pushed
the
yast_ftp_server
branch
from
d9565aa
to
1b18447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is a suite of tests for yast ftp server, this update fixed the lack support of SLE12sp5.
Needles: no
Verification run: