Add extra coverage for tcsh shell

[srlemke]

• Related ticket: https://progress.opensuse.org/issues/59354
• Needles: None
• Verification run:
  SLE 12.2 http://deathstar.suse.cz/tests/2061
  SLE 12.3 http://deathstar.suse.cz/tests/2059
  SLE 12.4 http://deathstar.suse.cz/tests/2060
  SLE 12.5 http://deathstar.suse.cz/tests/2058
  SLE 15.0 http://deathstar.suse.cz/tests/2057
  SLE 15.1 http://deathstar.suse.cz/tests/2062

Tumbleweed: http://deathstar.suse.cz/tests/2068

[okurz]

You seem to have a lot of verification runs. Why you would need that for every single SLE version I don't know but I suggest to have one for openSUSE TW which should be considered by default for verification because it should be considered always the most recent.

[srlemke]

Sorry saw to comment about opensuse TW only now.
Here is a run of TW: http://deathstar.suse.cz/tests/2065

I could not find out why it fails there, the fail is not introduced by this change. (but I will not have problems to fix it if we find the pb).

-- Also make sure the test runs on all supported products is a requirement by maintenance.

[okurz]

Sorry saw to comment about opensuse TW only now.
Here is a run of TW: http://deathstar.suse.cz/tests/2065

I could not find out why it fails there, the fail is not introduced by this change. (but I will not have problems to fix it if we find the pb).

I am not sure what test you used as template to trigger yours based on but it fails in http://deathstar.suse.cz/tests/2065#step/shells/17 because the permissions to access the serial device have not been adjusted. This is normally done as part of setup in a dedicated test module. You can of course also just boot a qcow image with Tumbleweed where this part had been done as part of the according installation test as well.

[srlemke]

yeah, that's the case as it passes fine on opensuse openqa.
Will clone a Tumbleweed and attach result here once it finishes.

[michelmno]

test is failing for leap15.2 ppc64le pas per https://openqa.opensuse.org/tests/1085853#step/shells/20
The failing line is:

validate_script_output 'grep -c tux:x:1001:100::/home/tux:/usr/bin/tcsh /tmp/tcsh', sub { /1/ };

may be interesting do add a post_fail_hook to report /tmp/tcsh for investigation.

[srlemke]

This grep needs an improvement, it currently matches a user ID 1001, but if the system has more users 1001 will be no match already.
I will also change user tux to something like tcsh_user to be less generic :)

Thanks for pointing this!