-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boot on encrypted disk for SLE15+ #9038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b13727
to
cc89cf0
Compare
d230478
to
a6f6dce
Compare
okurz
reviewed
Nov 29, 2019
bb97de3
to
372203e
Compare
okurz
reviewed
Dec 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Accidentally closed, reopenning. |
Fix poo#60083: Disk on SLE15+ is fully encrypted. Condition was not matching this situation properly and password request to unlock the disk was skipped. Function is_storage_ng didn't contain proper version check.
rwx788
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's merge when travis is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix poo#60083: Disk on SLE15+ is fully encrypted. Condition
was not matching this situation properly and password request to
unlock the disk was skipped.
x86_64:
SLE15: http://10.100.12.105/tests/3611
SLE12: http://10.100.12.105/tests/3612
aarch64:
SLE15: https://openqa.suse.de/t3644735
SLE12: not applicable
ppc64le:
SLE15: https://openqa.suse.de/tests/3644727
SLE12: https://openqa.suse.de/tests/3644728
Installation tests:
SLE15: http://10.100.12.105/tests/3619
SLE12: http://10.100.12.105/tests/3621