New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the modify_existing_partition for opensuse #9065
Merged
jknphy
merged 1 commit into
os-autoinst:master
from
b10n1k:fix_modify_existing_partition_opensuse
Dec 4, 2019
Merged
Fix the modify_existing_partition for opensuse #9065
jknphy
merged 1 commit into
os-autoinst:master
from
b10n1k:fix_modify_existing_partition_opensuse
Dec 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b10n1k
force-pushed
the
fix_modify_existing_partition_opensuse
branch
from
December 3, 2019 22:24
2d23a24
to
4fdc293
Compare
I neglected to verify os-autoinst#9024 against opensuse which makes it break. One of the problems was the test_data format. I dont cover the boot partition in this fix (do we need to for opensuse?) as we did for sle for now.
b10n1k
force-pushed
the
fix_modify_existing_partition_opensuse
branch
from
December 4, 2019 07:07
4fdc293
to
7a7f761
Compare
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 4, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 4, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 4, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 4, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 4, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 5, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
b10n1k
added a commit
to b10n1k/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 5, 2019
The changes from os-autoinst#9065 doesnt work for x86_94 and s390x. Trying to address the problem with the boot partition for aarch we affected the other archs as well. So with this PR we separate the test_data of aarch from the others
This was referenced Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I neglected to verify #9024
against opensuse which makes it break. One of the problems was the test_data format.
I dont cover the boot in this fix (do we need to?) as we did for sle for now.