orphaned_packages_check: Convert to automatic test failing on any orphans #9148
Conversation
okurz
force-pushed
the
feature/orphans
branch
from
517e64e
to
469ac38
Compare
okurz
changed the title
okurz
force-pushed
the
feature/orphans
branch
8 times, most recently
from
c65157b
to
ed98f4e
Compare
okurz
changed the title
okurz
force-pushed
the
feature/orphans
branch
from
ed98f4e
to
a610cae
Compare
|
Let me start from the basics and try to employ the good and efficient practices of reviews as I know them. While this is sane on it's own and a good idea overall, it touches main.pm flow and as such might be fairly disruptive to many tests used in various runs. For this reason, could you provide more verbose git commit message please? There is a problem in the git commit subject line length. Could you correct it please? Only after the formal improvements of your commits, I will look into the code. |
As proposed also by QA SLE PrjM we should check for orphaned packages in more products. This commit is adding the existing test module "orphaned_packages_check" in more test schedule flows, e.g. as part of zdup upgrade tests whereas previously it was used only in "upgrade" cases, e.g. medium based. Also adding this to more generic extra_tests_console as especially in installation-based scenarios there should be no unexpected orphan packages. Related progress issue: https://progress.opensuse.org/issues/47336
In fully supported systems there should be no orphaned packages. Exceptions can still be introduced with `record_soft_failure`. This change had also been suggested by SUSE QA SLE PrjM to have a proper automatic check rather than a list of orphan packages that would need to be checked manually. The test can still be instructed to not fail the test module by setting the test variable "ZYPPER_ORPHANED_CHECK_ONLY" to a true-value. Exceptions can be added to the according ignore-string. Related progress issue: https://progress.opensuse.org/issues/47333
okurz
force-pushed
the
feature/orphans
branch
from
a610cae
to
700a4e9
Compare
|
@schlad thx for review, updated git commit message. As you can see from the list of verification runs I know where this module is used and have triggered according tests, e.g. many QAM ones. |
|
All looks good. +2 |
|
@DimStar77 interesting. So packages that are specific to the live medium are already orphaned. So should we ignore "openSUSE-release" completely as well as "skelcd"? |
|
@DimStar77 see #9186 for a fix |
In fully supported systems there should be no orphaned packages.
Exceptions can still be introduced with
record_soft_failure.Verification runs:
Related progress issue: https://progress.opensuse.org/issues/47333