Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve script to find unused modules #9208

Merged
merged 5 commits into from
Jan 8, 2020

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Dec 19, 2019

  • Account for YAML scheduling
  • Account commented out modules and actual loadtest

Ticket: https://progress.opensuse.org/issues/60908

@asdil12 asdil12 marked this pull request as ready for review December 19, 2019 14:47
@okurz
Copy link
Member

okurz commented Dec 19, 2019

not sure how it's supposed to work. E.g. I see in https://travis-ci.org/os-autoinst/os-autoinst-distri-opensuse/jobs/627265370#L539 that "yast2_gui/yast2_users" is reported as unused – at least this is how I interpret the output – but git grep 'yast2_users' shows that it's used in schedule/yast/yast2_gui.yaml

@asdil12
Copy link
Member Author

asdil12 commented Dec 20, 2019

Finally found the issue. It should work now.

@okurz
Copy link
Member

okurz commented Dec 20, 2019

Now the exclusion with the follow-up grep does not work anymore. https://travis-ci.org/os-autoinst/os-autoinst-distri-opensuse/jobs/627661649#L465 reports zypper_moo, which should be excluded, same as more others

@asdil12
Copy link
Member Author

asdil12 commented Dec 20, 2019

Now I made this whitelist which was very crude a bit more explicit so that it should work with the new code.
There are still some unused modules reported now that the old code did not detect.

@asdil12 asdil12 merged commit 32ae2f0 into os-autoinst:master Jan 8, 2020
@asdil12 asdil12 deleted the unused_modules branch January 8, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants