Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yast2_clone_system to validate generated profile on stagingY #9233

Merged
merged 1 commit into from Jan 20, 2020
Merged

Add yast2_clone_system to validate generated profile on stagingY #9233

merged 1 commit into from Jan 20, 2020

Conversation

b10n1k
Copy link
Contributor

@b10n1k b10n1k commented Dec 31, 2019 •
edited

I updated the yaml scheduler.
I havent done any other change in test_suite.
REPO_SLE_MODULE_DEVELOPMENT_TOOLS is set to factory repo.
After installation of jing is removed.
Also I removed the xmllint.

http://aquarius.suse.cz/tests/1347 using http://download.opensuse.org/tumbleweed/repo/oss/

final VR with factory repo: http://aquarius.suse.cz/tests/1356

@jknphy
Copy link
Contributor

jknphy commented Jan 7, 2020 •
edited

Could you set to WIP and retry with newer build? 108.1 should be fine for trying out (the isos I mean, because the whole job group seems re-triggered showing partial results, but doesn't matter if the mediums have not changed).

rwx788
rwx788 reviewed Jan 8, 2020
View reviewed changes
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add this module to the test suite we run for daily builds, so we could easily bisect failures if something worked in staging and didn't work in the daily build. WDYT?

@rwx788 rwx788 added the notready label Jan 8, 2020
@rwx788
Copy link
Member

rwx788 commented Jan 8, 2020

Ok, I also remember now, why we haven't enabled this as development tools module is not build for staging, hence, we cannot install packages from it. And all of your failures are related to that.
But we also don't care from where jing or xmllint are coming from, so we can use other repos. As an alternative we can even validate xml on the worker side, which might require some magic to get tooling for the validation on them.

@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 8, 2020

Could you set to WIP and retry with newer build? 108.1 should be fine for trying out (the isos I mean, because the whole job group seems re-triggered showing partial results, but doesn't matter if the mediums have not changed).

i used latest build iso. 108.1 is the last builld but on stagingY is BuildY.101.1. What i try to say is that it doesnt make sense to try with 108.1

@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 8, 2020

I would also add this module to the test suite we run for daily builds, so we could easily bisect failures if something worked in staging and didn't work in the daily build. WDYT?

i would say that it is not necessary because it is covered from https://openqa.suse.de/tests/overview?arch=&machine=&modules=yast2_clone_system&distri=sle&version=15-SP2&build=120.1&groupid=129#.

@rwx788
Copy link
Member

rwx788 commented Jan 8, 2020

I would also add this module to the test suite we run for daily builds, so we could easily bisect failures if something worked in staging and didn't work in the daily build. WDYT?

i would say that it is not necessary because it is covered from https://openqa.suse.de/tests/overview?arch=&machine=&modules=yast2_clone_system&distri=sle&version=15-SP2&build=120.1&groupid=129#.

True, whereas these setups are different we still get profile with same sections and it's even better to have more keys/properties. Therefore, I guess we can skip this part.

@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 8, 2020

Ok, I also remember now, why we haven't enabled this as development tools module is not build for staging, hence, we cannot install packages from it. And all of your failures are related to that.
But we also don't care from where jing or xmllint are coming from, so we can use other repos. As an alternative we can even validate xml on the worker side, which might require some magic to get tooling for the validation on them.

I would like to discuss this further as i have some grasps to get the whole picture

@b10n1k b10n1k changed the title Add yast2_clone_system to validate generated profile on stagingY [WIP] Add yast2_clone_system to validate generated profile on stagingY Jan 9, 2020
@b10n1k b10n1k changed the title [WIP] Add yast2_clone_system to validate generated profile on stagingY Add yast2_clone_system to validate generated profile on stagingY Jan 9, 2020
@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 14, 2020

@jknphy i did the modifications for the jing installation(not submitted yet, will do it soon though) but unfortunately i cant run VR due to https://bugzilla.suse.com/show_bug.cgi?id=1160909

@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 14, 2020

@jknphy RFR without VR

@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 15, 2020

notready

@b10n1k b10n1k requested review from jknphy and rwx788 January 16, 2020 07:11
@b10n1k b10n1k force-pushed the poo49415 branch 2 times, most recently from ea25a78 to da43b3d Compare January 16, 2020 11:10
@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 16, 2020

RFR

@b10n1k
Copy link
Contributor Author

b10n1k commented Jan 16, 2020

@jknphy 4ccb591 addresses the comments about the gpg above. I removed -G and the condition in zypper_call '--gpg-auto-import-keys ref'; and VR was successful
http://aquarius.suse.cz/tests/1360#

@b10n1k b10n1k requested a review from jknphy January 16, 2020 16:37
@jknphy
Copy link
Contributor

jknphy commented Jan 17, 2020

@jknphy 4ccb591 addresses the comments about the gpg above. I removed -G and the condition in zypper_call '--gpg-auto-import-keys ref'; and VR was successful
http://aquarius.suse.cz/tests/1360#

Please, next time address comment individually as we agreed. And leave a while conversations unresolved so next person or the same person reviewing can have better look. Unless it is very trivial, I would recommend that you don't close yourself specially it is needed several rounds of review. It is more practical to use this feature of resolve conversation in a latter stage or review, so we can use it to discard stuff already accomplished.

@jknphy jknphy removed their request for review January 17, 2020 07:06
@b10n1k b10n1k force-pushed the poo49415 branch 2 times, most recently from 9f8e8c1 to 48c610c Compare January 17, 2020 13:20
@b10n1k b10n1k requested review from rwx788 and jknphy January 17, 2020 13:30
@jknphy jknphy removed their request for review January 17, 2020 14:17
jknphy
jknphy requested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@jknphy jknphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes to use a variable instead reusing existing one coming from build triggering.

@b10n1k b10n1k requested a review from jknphy January 17, 2020 15:05
@jknphy
Copy link
Contributor

jknphy commented Jan 20, 2020

LGTM

@b10n1k
Add yast2_clone_system to validate generated profile on stagingY
e865e67 
I updated the yaml scheduler.
I havent done any other change in test_suite.
factory repo is used in case of staging.
After installation of jing the repo is removed.
Also I removed the xmllint.
@b10n1k b10n1k requested a review from rwx788 January 20, 2020 11:16
@rwx788 rwx788 removed the notready label Jan 20, 2020
@rwx788 rwx788 merged commit 3ca872c into os-autoinst:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy approved these changes

@rwx788 rwx788 Awaiting requested review from rwx788

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@b10n1k @jknphy @rwx788