New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for installation with MSDOS partition table #9237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the minor changes that i am asking. Also rename new_table.pm to something else. i am struggling to find something to suggest.
Last but not least write a small description on your commit of what is this for and you have done(help the reviewer to understand whats going on)
7ef03ce
to
45ca526
Compare
lib/Installation/Partitioner/LibstorageNG/v4/ExpertPartitionerController.pm
Outdated
Show resolved
Hide resolved
ff1b1cf
to
1b9e6f2
Compare
b1511a6
to
f7a63c8
Compare
@sofiasyria LGTM and this PR had already a lot rounds of reviews so it should be fine even if we miss something. A couple of things: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused now, we already have test suite enabled in the job group, but neither this PR is merged nor any of the needles one. I believe we should not rush into enabling not finished tests not to pollute results for the daily builds.
I am not sure if enabling means adding the test to the Job Group. I did that because otherwise I could not run the tests with isos post, only with refspecs. Is there another way? |
cloning from another job of the target arch and modifying its params like YAML_SCHEDULE, etc. As Rodion mentioned, we should not enable in the overview things not working/finished, |
3c13aed
to
bd662eb
Compare
Missing points before merging that we could spot:
|
Good job, let's try it! |
Test for new installation on MSDOS partition table.
Related to :
https://progress.opensuse.org/issues/58915
Pull requests
Job groups (merged):
https://gitlab.suse.de/qsf-y/qa-sle-functional-y/merge_requests/115/
Needles:
os-autoinst/os-autoinst-needles-opensuse#641
and
https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/1322
should be also merged, in order that changes in "lib/Installation/Partitioner/FormattingOptionsPage.pm" will not break RAID tests.
(Looks like QAM doesn't use this library, so I don't see the need to duplicate needles for older sle versions.)
There is an issue with the validation_fs_table module on hyperv, that will be investigated separately.
Validation test on osd under name "msdos":
https://openqa.suse.de/tests/overview?distri=sle&version=15-SP2&build=139.4&groupid=129
Validation that raid_gpt doesn't break:
https://openqa.suse.de/tests/3905129