Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for installation with MSDOS partition table #9237

Merged
merged 1 commit into from Feb 20, 2020

Conversation

sofiasyria
Copy link
Contributor

@sofiasyria sofiasyria commented Jan 2, 2020

Test for new installation on MSDOS partition table.
Related to :
https://progress.opensuse.org/issues/58915

Pull requests
Job groups (merged):
https://gitlab.suse.de/qsf-y/qa-sle-functional-y/merge_requests/115/
Needles:
os-autoinst/os-autoinst-needles-opensuse#641
and
https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/1322
should be also merged, in order that changes in "lib/Installation/Partitioner/FormattingOptionsPage.pm" will not break RAID tests.
(Looks like QAM doesn't use this library, so I don't see the need to duplicate needles for older sle versions.)

There is an issue with the validation_fs_table module on hyperv, that will be investigated separately.

Validation test on osd under name "msdos":
https://openqa.suse.de/tests/overview?distri=sle&version=15-SP2&build=139.4&groupid=129
Validation that raid_gpt doesn't break:
https://openqa.suse.de/tests/3905129

Copy link
Contributor

@b10n1k b10n1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the minor changes that i am asking. Also rename new_table.pm to something else. i am struggling to find something to suggest.

Last but not least write a small description on your commit of what is this for and you have done(help the reviewer to understand whats going on)

\ Outdated Show resolved Hide resolved
lib/partitions_validator_utils.pm Outdated Show resolved Hide resolved
lib/partitions_validator_utils.pm Outdated Show resolved Hide resolved
schedule/yast/msdos.yaml Show resolved Hide resolved
tests/console/validate_fs_table.pm Outdated Show resolved Hide resolved
schedule/yast/msdos.yaml Outdated Show resolved Hide resolved
@sofiasyria sofiasyria changed the title [WIP] Add test msdos: installation with MSDOS partition table. [WIP] Add test msdos: installation with MSDOS partition table Feb 13, 2020
@sofiasyria sofiasyria changed the title [WIP] Add test msdos: installation with MSDOS partition table [WIP] Add test for installation with MSDOS partition table Feb 13, 2020
@sofiasyria sofiasyria changed the title [WIP] Add test for installation with MSDOS partition table Add test for installation with MSDOS partition table Feb 17, 2020
@jknphy
Copy link
Contributor

jknphy commented Feb 17, 2020

@sofiasyria LGTM and this PR had already a lot rounds of reviews so it should be fine even if we miss something. A couple of things:
Could you comment failures in your verifications (even just saying that are not related with this task) but at least to discard any other problem.
In the meantime some other reviewer gives ok, if you want you can prepare YAML Job group PR and paste link in the first comment.

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused now, we already have test suite enabled in the job group, but neither this PR is merged nor any of the needles one. I believe we should not rush into enabling not finished tests not to pollute results for the daily builds.

@sofiasyria
Copy link
Contributor Author

I'm a bit confused now, we already have test suite enabled in the job group, but neither this PR is merged nor any of the needles one. I believe we should not rush into enabling not finished tests not to pollute results for the daily builds.

I am not sure if enabling means adding the test to the Job Group. I did that because otherwise I could not run the tests with isos post, only with refspecs. Is there another way?

@jknphy
Copy link
Contributor

jknphy commented Feb 17, 2020

I'm a bit confused now, we already have test suite enabled in the job group, but neither this PR is merged nor any of the needles one. I believe we should not rush into enabling not finished tests not to pollute results for the daily builds.

I am not sure if enabling means adding the test to the Job Group. I did that because otherwise I could not run the tests with isos post, only with refspecs. Is there another way?

cloning from another job of the target arch and modifying its params like YAML_SCHEDULE, etc. As Rodion mentioned, we should not enable in the overview things not working/finished, openqa-clone-custom-git-refspec is what we normally use, for very peculiar scenarios like Multi Machine, isos post could be useful. Otherwise we have test failing in the overview and there is a automation in place to report those failures to release managers plus our own effort to label them, so it is always better try the other path first.

@jknphy
Copy link
Contributor

jknphy commented Feb 20, 2020

Missing points before merging that we could spot:

  • Rerun verifications (optionally comment the ones failing if related or not with this task)
  • Fix commit message

@jknphy
Copy link
Contributor

jknphy commented Feb 20, 2020

Good job, let's try it!

@jknphy jknphy merged commit 105575d into os-autoinst:master Feb 20, 2020
@sofiasyria sofiasyria deleted the beta branch March 26, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants