Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor zypper orphan test case #9263

Merged
merged 1 commit into from Jan 16, 2020

Conversation

mloviska
Copy link
Contributor

@mloviska mloviska commented Jan 8, 2020

Registered JeOS image should not have any orphans or mini-* packages installed. In case JeOS is not registered against SDK module, we should expect 3 packages as orphans

  1. live-langset-data
  2. jeos-licenses
  3. jeos-firstboot

Anything else should be denoted and reported as a bug.

@mloviska mloviska added the WIP Work in progress label Jan 8, 2020
@mloviska mloviska force-pushed the jeos_orphans_whitelist branch 7 times, most recently from a6c72f7 to 5b2ad93 Compare January 10, 2020 16:04
@mloviska mloviska added Ready Ready for review and removed WIP Work in progress labels Jan 10, 2020
@mloviska mloviska added WIP Work in progress and removed Ready Ready for review labels Jan 14, 2020
@mloviska mloviska force-pushed the jeos_orphans_whitelist branch 2 times, most recently from 427915c to d3082d6 Compare January 15, 2020 12:13
@mloviska mloviska changed the title Move orphan check to main test suite Refactor zypper orphan test case Jan 15, 2020
tests/console/orphaned_packages_check.pm Outdated Show resolved Hide resolved
tests/console/orphaned_packages_check.pm Outdated Show resolved Hide resolved
tests/console/orphaned_packages_check.pm Show resolved Hide resolved
@mloviska mloviska force-pushed the jeos_orphans_whitelist branch 2 times, most recently from 6ac4920 to 10c9db5 Compare January 15, 2020 16:40
@mloviska mloviska removed the WIP Work in progress label Jan 15, 2020
@mloviska mloviska merged commit 0018e37 into os-autoinst:master Jan 16, 2020
@mloviska mloviska deleted the jeos_orphans_whitelist branch January 16, 2020 09:38
@nilxam
Copy link
Member

nilxam commented Jan 16, 2020

https://openqa.opensuse.org/tests/1145792#step/orphaned_packages_check/3 does that mean I need to set ZYPPER_WHITELISTED_ORPHANS?

@nilxam
Copy link
Member

nilxam commented Jan 17, 2020

ok, I set ZYPPER_WHITELISTED_ORPHANS on 15.2/15.2 ARM/15.2 PowerPC/LiveCDs and other images.

@mloviska
Copy link
Contributor Author

ok, I set ZYPPER_WHITELISTED_ORPHANS on 15.2/15.2 ARM/15.2 PowerPC/LiveCDs and other images.

Yup, that is how it should be solved generally. But this might be a problem in the test case itself. It will be a problem with other flavors as well.
I will handle it in a separate PR. Thanks for the report

@nilxam
Copy link
Member

nilxam commented Jan 17, 2020

ok, I set ZYPPER_WHITELISTED_ORPHANS on 15.2/15.2 ARM/15.2 PowerPC/LiveCDs and other images.

Yup, that is how it should be solved generally. But this might be a problem in the test case itself. It will be a problem with other flavors as well.
I will handle it in a separate PR. Thanks for the report

I handled ZYPPER_WHITELISTED_ORPHANS on all 15.2 flavors, you can check it on o3. Need some love for Tumbleweed(and its flavor builds), latest Tumbleweed snapshot is tested without this change.

@mloviska
Copy link
Contributor Author

ok, I set ZYPPER_WHITELISTED_ORPHANS on 15.2/15.2 ARM/15.2 PowerPC/LiveCDs and other images.

Yup, that is how it should be solved generally. But this might be a problem in the test case itself. It will be a problem with other flavors as well.
I will handle it in a separate PR. Thanks for the report

I handled ZYPPER_WHITELISTED_ORPHANS on all 15.2 flavors, you can check it on o3. Need some love for Tumbleweed(and its flavor builds), latest Tumbleweed snapshot is tested without this change.

Thanks a lot, I have created a hotfix PR
#9355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants