Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not increase memory for kdump anymore #9269

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Do not increase memory for kdump anymore #9269

merged 1 commit into from
Jan 10, 2020

Conversation

SergioAtSUSE
Copy link
Member

@SergioAtSUSE SergioAtSUSE commented Jan 8, 2020 •
edited
Loading

@binary-sequence
Do not increase memory for kdump anymore
4170c05 
Workaround for bsc#1120566 is removed
@SergioAtSUSE SergioAtSUSE marked this pull request as ready for review January 9, 2020 16:42
Zaoliang
Zaoliang approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@Zaoliang Zaoliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zaoliang Zaoliang merged commit 0f48f71 into os-autoinst:master Jan 10, 2020
@SergioAtSUSE SergioAtSUSE deleted the remove_kdump_workaround branch January 10, 2020 12:20
@czerw
Copy link
Contributor

czerw commented Jan 20, 2020 •
edited
Loading

Why was memory increase removed? Kdump on ppcle64 started to fail after this change https://openqa.suse.de/tests/3809953#step/kdump_and_crash/67.

@SergioAtSUSE
Copy link
Member Author

SergioAtSUSE commented Jan 20, 2020 •
edited
Loading

@czerw, it was working: https://progress.opensuse.org/issues/61082#note-6
https://bugzilla.suse.com/show_bug.cgi?id=1120566

Is it sporadic? or maybe something different?

@SergioAtSUSE
Copy link
Member Author

Also, this look like another issue: https://openqa.suse.de/tests/3809953#step/kdump_and_crash/64

@czerw
Copy link
Contributor

czerw commented Jan 20, 2020

Not sporadic, and you can see that we have OOM and it even started to fail on leap https://progress.opensuse.org/issues/61907. Don't worry I will continue and fix it.

@SergioAtSUSE
Copy link
Member Author

SergioAtSUSE commented Jan 20, 2020 •
edited
Loading

Yes, I see OOM, but, something else is happening.
The workaround was breaking our tests for SP2 on aarch64 and ppc64, because kdump failed to reserve memory when it was increased by the workaround.
The bug was marked as resolved and the tests worked removing the workaround.
So, if it wasn't sporadic, the removal of the workaround has nothing to do with the new failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaoliang Zaoliang Zaoliang approved these changes

@Soulofdestiny Soulofdestiny Awaiting requested review from Soulofdestiny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SergioAtSUSE @czerw @Zaoliang @binary-sequence