livecdreboot - rename and tidy #9716

[MalloZup]

tested with opensuse && slle version, tested with flag Boot_to_snapshot = 1/0 -> OK

The commit is applicable also for main.pm branch SLE12, so the main.pm contains the same change.
" livecdreboot" -> reboot_after install

• grub tests of livecdreboot are moved to first_boot
  here we have a enforced test for avoid grub timeout, since we had failure because needles matching taked to long (first_boot.pm)
• only one question: on opensuse branch there was a test already reboot_after_install.pm. i removed this, because i saw no utilisation of this test. ( it tested only a needle)

[sysrich]

Hi Dario! Thanks - I'm going to pop over to your desk in a second and we can work through this PR :)

[coolo]

I'd prefer if the waiting_for_reboot is seperated from the reboot_after_installation

[sysrich]

Because I don't understand, are you suggesting we should go for 3 test modules?
waiting_for_reboot which would effectively be reboot_after_install lines 17-48? (or lines 17-52 to get the yast logs also?)
then reboot_after_installation which would be reboot_after_install lines 54-58?
then first_boot?

[coolo]

Yes, I think I'd prefer that. because 99% of reboot_after_install is the install and 1% is the reboot :)

[MalloZup]

-> so we made 3 tests instead of 2 tests ?

reboot_after_install lines 17-52 -> waiting_for_reboot
reboot_after_installation 54-58 -> grub_test || reboot_after_installation. for me grub_test it's clearer
first_boot rest unchanged?