Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra_tests_gnome_sdk scenario #9410

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

DrMullings
Copy link
Contributor

And put extra_tests_on_gnome to yaml

@DrMullings
Copy link
Contributor Author

@SergioAtSUSE please take a look, whether I overlooked something

name: extra_tests_gnome
description: >
Maintainer: asmorodskyi, okurz.
Extra tests which were designed to run on gnome , VNC_STALL_THRESHOLD is needed for xen svirt to don't turn off the scrreen after default 4 sec
Copy link
Member

@SergioAtSUSE SergioAtSUSE Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, it should mention explicitly that is to test packages from following modules

  • Basesystem Actually this should be done in extra_tests_in_textmode
  • Server applications Actually this should be done in extra_tests_in_textmode
  • Desktop applications

Since > allows multi line, VNC_STALL_THRESHOLD can be split in another line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules list corrected

description: >
Maintainer: asmorodskyi, okurz.
Extra tests which were designed to run on gnome , VNC_STALL_THRESHOLD is needed for xen svirt to don't turn off the scrreen after default 4 sec
schedule:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that you will add the missing test modules? https://openqa.suse.de/tests/3796732

description: >
Maintainer: jrauch
Extra tests about software in sdk on gnome
schedule:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that at the last module executed for extra tests scenarios is console/coredump_collect.
I think we should include it here too.
e.g.: https://openqa.suse.de/tests/3796732#step/coredump_collect/4

Extra tests about software in sdk on gnome
schedule:
-boot/boot_to_desktop
-console/prepare_test_data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should in the future schedule those "preparation" tests in the create_hdd_* scenarios, to not repeat them for each extra tests testsuite.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense, but is outside the scope of this ticket

Copy link
Member

@SergioAtSUSE SergioAtSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Still WIP?

@DrMullings DrMullings changed the title [WIP] Add extra_tests_gnome_sdk scenario Add extra_tests_gnome_sdk scenario Jan 22, 2020
@DrMullings
Copy link
Contributor Author

Not from my side

name: extra_tests_gnome
description: >
Maintainer: asmorodskyi, okurz.
Extra tests which were designed to run on gnome >
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I confused you. The '>' is only needed after description field.

Suggested change
Extra tests which were designed to run on gnome >
Extra tests from desktop applications module which were designed to run on gnome

- boot/boot_to_desktop
- console/preapre/test_data
- console/consoletest_setup
- x11/vnc_two_passwords
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing x11/user_defined_snapshot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

name: extra_tests_gnome
description: >
Maintainer: asmorodskyi, okurz.
Extra tests which were designed to run on gnome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, it should mention explicitly that is to test packages from Desktop applications module

Suggested change
Extra tests which were designed to run on gnome
Extra tests for software in desktop applications module which were designed to run on gnome

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forgot about that

Copy link
Member

@SergioAtSUSE SergioAtSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for verification runs

@DrMullings
Copy link
Contributor Author

Verification:
https://openqa.suse.de/tests/3821615

@DrMullings
Copy link
Contributor Author

Verification extra_tests_gnome
https://openqa.suse.de/tests/3821632#settings

@DrMullings
Copy link
Contributor Author

New verification extra tests on gnome
https://openqa.suse.de/tests/3821633

And put extra_tests_on_gnome to yaml
@DrMullings
Copy link
Contributor Author

Final verification for extra tests on gnome:
https://openqa.suse.de/tests/3821643

@SergioAtSUSE
Copy link
Member

Awesome!

@SergioAtSUSE SergioAtSUSE merged commit 7b4444c into os-autoinst:master Jan 23, 2020
@SergioAtSUSE SergioAtSUSE deleted the move_libqt branch January 23, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants