Do not kill inexistent process from user postgress #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test failed because kill process was missing the parameter PID, which was sent empty.
foursixnine
reviewed
Feb 17, 2020
| @@ -346,7 +346,7 @@ sub postgresql_cleanup { | |||
| systemctl 'stop postgresql'; | |||
| systemctl 'disable postgresql'; | |||
| systemctl 'is-active postgresql', expect_false => 1; | |||
| assert_script_run q{kill -s KILL $(ps -u postgres -o pid=)}; | |||
| assert_script_run('kill -s KILL $(ps -u postgres -o pid=)') unless script_run('ps -u postgres -o pid='); | |||
There was a problem hiding this comment.
line 346 should deal with postgresql server, as it should stop upon received signal, and postmaster process should be dead by then.
foursixnine
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failed because kill process was missing the parameter PID, which
was sent empty.