Do not assert_screen using serial terminal #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foursixnine
reviewed
Feb 19, 2020
lib/opensusebasetest.pm
Outdated
| @@ -49,7 +49,7 @@ sub clear_and_verify_console { | |||
| my ($self) = @_; | |||
|
|
|||
| clear_console; | |||
| assert_screen('cleared-console'); | |||
| assert_screen('cleared-console') unless testapi::is_serial_terminal(); | |||
There was a problem hiding this comment.
please use:
use testapi qw(is_serial_terminal :DEFAULT);
so that you can call directly is_serial_terminal()
The test module suseconnect_scc uses serial terminal, which doesn't support screenshots and therefore causes unreliable behavior.
SergioAtSUSE
force-pushed
the
postreg
branch
from
2b9ad45
to
69c5f15
Compare
|
New verification run: http://openqa.slindomansilla-vm.qa.suse.de/tests/2226 |
foursixnine
approved these changes
Feb 19, 2020
okurz
reviewed
Feb 21, 2020
| @@ -49,7 +49,7 @@ sub clear_and_verify_console { | |||
| my ($self) = @_; | |||
|
|
|||
| clear_console; | |||
| assert_screen('cleared-console'); | |||
| assert_screen('cleared-console') unless is_serial_terminal(); | |||
There was a problem hiding this comment.
what do you do instead on the serial terminal? If you don't have this synchronisation points then I am sure followup test calls will fail. Otherwise the complete method would be useless, isn't it? Or in other words: Probably clear_and_verify_console really doesn't make any sense on serial terminals, does it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test module suseconnect_scc uses serial terminal, which doesn't
support screenshots and therefore causes unreliable behavior.