Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check urlbar selected before typing in chromium #9580

Merged
merged 1 commit into from Feb 20, 2020
Merged

Check urlbar selected before typing in chromium #9580

merged 1 commit into from Feb 20, 2020

Conversation

asdil12
Copy link
Member

@asdil12 asdil12 commented Feb 19, 2020

@asdil12 asdil12 marked this pull request as ready for review February 19, 2020 16:06
@SergioAtSUSE
Copy link
Member

I suppose this is the verification: http://artemis.suse.de/tests/2267#step/chromium/25

@asdil12
Copy link
Member Author

asdil12 commented Feb 20, 2020

yes

@SergioAtSUSE SergioAtSUSE merged commit 33aab83 into os-autoinst:master Feb 20, 2020
@okurz
Copy link
Member

okurz commented Feb 21, 2020

please fix the typo "hightlighted" in the needle tag and needle name.

@okurz
Copy link
Member

okurz commented Feb 21, 2020

as you introduced an explicit needle check now can you try to remove the wait_still_screen and wait_screen_change calls which are redundant?

This was referenced Feb 21, 2020
Merged
Merged
@DimStar77
Copy link
Contributor

https://openqa.opensuse.org/tests/overview?arch=&machine=&modules=&todo=1&distri=microos&distri=opensuse&version=Tumbleweed&build=20200220&groupid=1#

Quite a few chromium failures accumulating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioAtSUSE SergioAtSUSE SergioAtSUSE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@asdil12 @SergioAtSUSE @okurz @DimStar77