Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Travis check for YAML_TEST_DATA in yaml schedule #9907

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add Travis check for YAML_TEST_DATA in yaml schedule #9907

merged 1 commit into from
Apr 2, 2020

Conversation

sofiasyria
Copy link
Contributor

@sofiasyria sofiasyria commented Mar 27, 2020 •
edited
Loading

Amplification of Travis checks in order to cover scenario where YAML_TEST_DATA variable is defined in yaml schedule's vars, to point to test data file.

@sofiasyria sofiasyria force-pushed the ac64752 branch 19 times, most recently from 71345df to 100377a Compare March 31, 2020 11:56
rwx788
rwx788 reviewed Mar 31, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@sofiasyria sofiasyria changed the title [WIP][not_ready] Add Travis check for YAML_TEST_DATA in yaml schedule Add Travis check for YAML_TEST_DATA in yaml schedule Mar 31, 2020
@sofiasyria sofiasyria force-pushed the ac64752 branch 4 times, most recently from bc48b78 to 472c6c6 Compare April 2, 2020 09:50
rwx788
rwx788 approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwx788
Copy link
Member

rwx788 commented Apr 2, 2020

Just to be sure, have you tested latest version? As travis runs are from yesterday and last push was 3 hours ago. Static code analysis is good, but running still can show things we have missed =).

@sofiasyria sofiasyria force-pushed the ac64752 branch 2 times, most recently from 18281ee to dbc2105 Compare April 2, 2020 13:47
@sofiasyria
Copy link
Contributor Author

Just to be sure, have you tested latest version? As travis runs are from yesterday and last push was 3 hours ago. Static code analysis is good, but running still can show things we have missed =).

Today I changed the tabs to spaces in tools/test_deleted_renamed_referenced_files . I just rerun the validation test that concerns that part of the pull request and replaced the verification link on the description.

@rwx788 rwx788 merged commit 230960c into os-autoinst:master Apr 2, 2020
@rwx788
Copy link
Member

rwx788 commented Apr 3, 2020

Breaks in case no test data is in the schedule: https://travis-ci.org/github/os-autoinst/os-autoinst-distri-opensuse/jobs/670463776?utm_medium=notification&utm_source=github_status
Reverting to fix without stress.

@rwx788 rwx788 mentioned this pull request Apr 3, 2020
Merged
@sofiasyria sofiasyria mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwx788 rwx788 rwx788 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sofiasyria @rwx788