New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publiccloud: Boottime thresholds per flavor #9977
publiccloud: Boottime thresholds per flavor #9977
Conversation
Also fixed http://openqa-perf.qa.suse.de/d/A-z8Cz0Zz/systemd-analyze-blame view. |
tests/publiccloud/boottime.pm
Outdated
my $threshold_by_flavor = { | ||
qr/^(Azure-Standard|Azure-Basic)$/ => { | ||
overall => 3 * 60, | ||
userspace => 3 * 60, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall should be higher than userspace, right?
Why are you setting now overall to 180 if it was 160 in the default list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
According to the discussion with PC team, the idea was to have it per provider, not per flavor. I know doing it per flavor is more flexible, but I wonder if it would be clearer to have only 3 values for each parameter (1 value per provider), something like a matrix, instead of patching some default values. |
I second that , instead of programmatically nice looking thingy I would prefer to have clear matrix split by provider |
I don't like the idea of having it per provider. At least we should separate between BYOS and On-Demand. Look at Azure http://s.qa.suse.de/KS1y there is a diff of 1min between them. |
They also had the idea to separate per instance-type. So I guess this isn't the last iteration and I would keep the config-matrix as small as possible, but flexible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2f2b5e9
to
f940f9f
Compare
We get very different timings for boottime validation. So we need to specify thresholds per FLAVOR.
f940f9f
to
94c9360
Compare
We get very different timings for boottime validation. So we need to
specify thresholds per FLAVOR.