Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publiccloud: Boottime thresholds per flavor #9977

Merged

Conversation

cfconrad
Copy link
Contributor

@cfconrad cfconrad commented Apr 6, 2020

We get very different timings for boottime validation. So we need to
specify thresholds per FLAVOR.

@cfconrad cfconrad requested a review from jlausuch April 6, 2020 16:29
@cfconrad
Copy link
Contributor Author

cfconrad commented Apr 6, 2020

my $threshold_by_flavor = {
qr/^(Azure-Standard|Azure-Basic)$/ => {
overall => 3 * 60,
userspace => 3 * 60,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall should be higher than userspace, right?
Why are you setting now overall to 180 if it was 160 in the default list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@jlausuch
Copy link
Contributor

jlausuch commented Apr 7, 2020

According to the discussion with PC team, the idea was to have it per provider, not per flavor. I know doing it per flavor is more flexible, but I wonder if it would be clearer to have only 3 values for each parameter (1 value per provider), something like a matrix, instead of patching some default values.

@asmorodskyi
Copy link
Member

According to the discussion with PC team, the idea was to have it per provider, not per flavor. I know doing it per flavor is more flexible, but I wonder if it would be clearer to have only 3 values for each parameter (1 value per provider), something like a matrix, instead of patching some default values.

I second that , instead of programmatically nice looking thingy I would prefer to have clear matrix split by provider

@cfconrad
Copy link
Contributor Author

cfconrad commented Apr 7, 2020

I don't like the idea of having it per provider. At least we should separate between BYOS and On-Demand. Look at Azure http://s.qa.suse.de/KS1y there is a diff of 1min between them.

@cfconrad
Copy link
Contributor Author

cfconrad commented Apr 7, 2020

According to the discussion with PC team, the idea was to have it per provider, not per flavor.

They also had the idea to separate per instance-type. So I guess this isn't the last iteration and I would keep the config-matrix as small as possible, but flexible.

Copy link
Member

@asmorodskyi asmorodskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfconrad cfconrad force-pushed the fix/boottime_settings_per_flavor branch from 2f2b5e9 to f940f9f Compare April 7, 2020 13:03
We get very different timings for boottime validation. So we need to
specify thresholds per FLAVOR.
@cfconrad cfconrad force-pushed the fix/boottime_settings_per_flavor branch from f940f9f to 94c9360 Compare April 7, 2020 15:01
@jlausuch jlausuch merged commit d5c76fc into os-autoinst:master Apr 7, 2020
@cfconrad cfconrad deleted the fix/boottime_settings_per_flavor branch April 7, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants