Fail when detecting wrong desktop - 2nd try #9982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
changed the title
jknphy
force-pushed
the
detect_wrong_desktop
branch
from
844679c
to
2972f52
Compare
rwx788
reviewed
Apr 7, 2020
After performing wide search in OSD/O3 to find scenarios where we were displaying info box about mismatching, now we can die when detecting wrong desktop and at the same time improve a bit the validation to assert expected vs actual result. hmc/pvm_hmc excluded at the moment due to problems switching tty.
jknphy
force-pushed
the
detect_wrong_desktop
branch
from
2972f52
to
10be8d2
Compare
|
You just removed |
oh! sorry for that, I deleted accidentally, adding it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After performing wide search in OSD/O3 to find scenarios where
we were displaying info box about mismatching, now we can die
when detecting wrong desktop and at the same time
improve a bit the validation to assert expected vs actual result.
hmc/pvm_hmc excluded at the moment due to problems switching tty.
*this is second try after #9882 where now we exclude PATTERNS as well.