Add autoyast test for yast2-ntp-client systemd timers #9988
Conversation
sofiasyria
force-pushed
the
ac61946
branch
2 times, most recently
from
c4a4adb
to
1090638
Compare
sofiasyria
changed the title
sofiasyria
force-pushed
the
ac61946
branch
2 times, most recently
from
c80d475
to
db3b454
Compare
sofiasyria
force-pushed
the
ac61946
branch
3 times, most recently
from
605b0ba
to
cb0fa59
Compare
sofiasyria
force-pushed
the
ac61946
branch
3 times, most recently
from
03ee938
to
a9ddb1e
Compare
sofiasyria
force-pushed
the
ac61946
branch
2 times, most recently
from
095f947
to
46811df
Compare
sofiasyria
changed the title
sofiasyria
force-pushed
the
ac61946
branch
5 times, most recently
from
cb7b1a6
to
f0ce9a3
Compare
sofiasyria
force-pushed
the
ac61946
branch
3 times, most recently
from
795d464
to
8df7e8a
Compare
sofiasyria
force-pushed
the
ac61946
branch
2 times, most recently
from
a119647
to
0bfa2df
Compare
| my $expected_server = $test_data->{profile}->{'ntp-client'}->{ntp_servers}->{ntp_server}->{address}; | ||
| my $chrony_conf = script_output("cat /etc/chrony.conf"); | ||
| $chrony_conf =~ /(\R|^)pool\s(?<server>(\S+))/; | ||
| assert_equals($expected_server, $+{server}); |
There was a problem hiding this comment.
In case of multiple server addresses, only the first one will be taken under consideration.
There was a problem hiding this comment.
I guess it is ok for this test and probably not needed a comment as the regex does not have g modifier /regex/g so only one match is expected. Otherwise it would need a loop.
| record_info("Check server", "Check if the configured time synchronization server is the expected one."); | ||
| my $expected_server = $test_data->{profile}->{'ntp-client'}->{ntp_servers}->{ntp_server}->{address}; | ||
| my $chrony_conf = script_output("cat /etc/chrony.conf"); | ||
| $chrony_conf =~ /(\R|^)pool\s(?<server>(\S+))/; |
There was a problem hiding this comment.
minor detail: why not just: ^pool\s(?<server>\S+) ? it would detect it even there is not line on top of the searched one and the parenthesis sorrounding \S+ probably not needed due to the named group already created a group.
There was a problem hiding this comment.
I thought that since it is a conf file, somebody who might use the module could have comments above "pool" . In that case, ^pool wouldn't work. I just tried removing the parenthesis from \S+ and it also works. I will change that.
There was a problem hiding this comment.
comments starts with # in that file? sure it shouldn't match?
| my $expected_server = $test_data->{profile}->{'ntp-client'}->{ntp_servers}->{ntp_server}->{address}; | ||
| my $chrony_conf = script_output("cat /etc/chrony.conf"); | ||
| $chrony_conf =~ /(\R|^)pool\s(?<server>(\S+))/; | ||
| assert_equals($expected_server, $+{server}); |
There was a problem hiding this comment.
I guess it is ok for this test and probably not needed a comment as the regex does not have g modifier /regex/g so only one match is expected. Otherwise it would need a loop.
| ntp_servers: | ||
| ntp_server: | ||
| address: cz.pool.ntp.org | ||
| ntp_sync: 1 |
There was a problem hiding this comment.
As per our discussion, I will create ticket so we could use same format for validation and variables expansion in AY profiles.
yast2-ntp-client is using systemd timers instead of cron, when configured to perform one time synchronization. This test verifies that particular function works as configured.