New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sshXtermIPMI] Overrides reset function for ipmi console #1021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
- Coverage 40.19% 39.77% -0.42%
==========================================
Files 34 34
Lines 4526 4526
Branches 771 771
==========================================
- Hits 1819 1800 -19
- Misses 2389 2408 +19
Partials 318 318
Continue to review full report at Codecov.
|
LGTM |
Hi @foursixnine @mitiao, please do not merge now, we are trying to fix half-open issue in the roots, maybe need to change this PR. |
I don't think your change is a "refactoring", especially as you are adding a new method. I suggest to rephrase the commit message and PR subject |
@okurz Yes, i will change the RP subject |
Hi Reviewers: This is a single/whole fix for supporing dell/super-micro machine, please re-open review process. @foursixnine @mitiao |
@XGWang0 Do you have any proof runs? |
@alvarocarvajald Mind testing this commit in your os-autoinst? (@coolo wdyt could be related?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
OK, this seems to do the trick in my development system. Test is able to pass |
@SergioAtSUSE might be interesting for you |
@foursixnine No extra test run except verification run in comment i posted. |
Make sure sol connection is deactivated after reset (rest_consoles) operation, which guarantees it is successful for sol connecting again.