Remove disable related code due to it will aggravate half-open issue #5722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has to be merged after PR#1021: is deployed if I understood @alice-suse correctly... |
|
@foursixnine yes, you are right, this is combination fix. |
|
Hi reviewers, please keep this PR now, we are trying to fix half-open issue in the roots, may need to change this PR. |
|
This rely on os-autoinst/os-autoinst#1021. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove console()->disable code due to it cause half-open issue. Although i can not solve the issue in the roots, it reduce issue probability at least.
Related ticket:
poo#32746
Verification run:
test on super-micro machine : http://10.67.19.191/tests/209
test on dell machine : http://10.67.19.191/tests/201
test for xen on dell machine: http://10.67.132.86/tests/170