Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: add tools/update-deps #1416

Merged
merged 2 commits into from
May 26, 2020
Merged

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented May 22, 2020

Issue: https://progress.opensuse.org/issues/56525

I took the script from openQA and added some parameters, so that it can be used for both repos.
Then we can remove it in openQA and use this one instead.

I tested it in openQA and it works.

@perlpunk
Copy link
Contributor Author

Still have to add a test for it

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #1416 into master will increase coverage by 0.53%.
The diff coverage is 92.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage   54.47%   55.00%   +0.53%     
==========================================
  Files          52       53       +1     
  Lines        6179     6268      +89     
==========================================
+ Hits         3366     3448      +82     
- Misses       2813     2820       +7     
Impacted Files Coverage Δ
tools/update-deps 92.13% <92.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ca922...093f739. Read the comment docs.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 test would be good

@perlpunk perlpunk force-pushed the autodeps branch 3 times, most recently from 6442be9 to 0adc06b Compare May 22, 2020 17:10
@perlpunk
Copy link
Contributor Author

Added a test

@perlpunk perlpunk merged commit 0586d62 into os-autoinst:master May 26, 2020
@perlpunk perlpunk deleted the autodeps branch May 27, 2020 08:47
@AdamWill
Copy link
Contributor

AdamWill commented Jun 8, 2020

why did you put MakeMaker in main_requires? Surely it should be in build_requires?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants