Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Install isotovideo as executable #1484

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Conversation

Martchus
Copy link
Contributor

  • Covers os-autoinst-openvswitch as well
  • Since these scripts are not an executable target they are apparently
    not installed with execution permissions by default

* Covers os-autoinst-openvswitch as well
* Since these scripts are not an executable target they are apparently
  not installed with execution permissions by default
@Martchus
Copy link
Contributor Author

This problem could have been observed by our test package builds:

[   90s] + isotovideo --help
[   90s] /var/tmp/rpm-tmp.0G3eZM: line 34: /usr/bin/isotovideo: Permission denied

That's actually where I've discovered it. Unfortunately our "OBS Package Build" check doesn't include those packages.

@codecov
Copy link

codecov bot commented Jul 24, 2020

Codecov Report

Merging #1484 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1484   +/-   ##
=======================================
  Coverage   56.13%   56.13%           
=======================================
  Files          54       54           
  Lines        6362     6362           
=======================================
  Hits         3571     3571           
  Misses       2791     2791           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd050f8...60ab237. Read the comment docs.

@Martchus Martchus merged commit 8ad63f7 into os-autoinst:master Jul 24, 2020
@Martchus Martchus deleted the cmake branch July 24, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant