docker: Add Dockerfile for isotovideo+qemu-x86 #1567
Conversation
This comment has been minimized.
This comment has been minimized.
okurz
force-pushed
the
feature/ci_standalone_isotovideo_only_container_poo77905
branch
from
14fe013
to
83387ca
Compare
okurz
changed the title
The full warning is: section title out of sequence: expected level 2, got level 3
I had https://build.opensuse.org/package/view_file/home:okurz:container/isotovideo/Dockerfile since about a year. This commit pushes that upstream to os-autoinst and adapts to work in more general CI pipelines in a limited way, e.g. also github actions where no nested virt and hence no KVM is available. With this commit we can publish the container and image as an easier entry point for users and also to be used within CI pipelines of other projects. The same Dockerfile configuration was used in https://build.opensuse.org/package/view_file/home:okurz:container/isotovideo-qemu-x86/Dockerfile?expand=1 which in turn was used in os-autoinst/os-autoinst-distri-example#4 to show how isotovideo can be run as part of a CI pipeline using github actions. Related progress issue: https:/progress.opensuse.org/issues/77905
okurz
force-pushed
the
feature/ci_standalone_isotovideo_only_container_poo77905
branch
from
83387ca
to
5916c98
Compare
Codecov Report
@@ Coverage Diff @@
## master #1567 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 56 56
Lines 6546 6544 -2
=======================================
- Hits 3954 3953 -1
+ Misses 2592 2591 -1
Continue to review full report at Codecov.
|
| #!BuildTag: isotovideo:qemu-x86 | ||
|
|
||
| FROM opensuse/tumbleweed | ||
| RUN zypper -n in os-autoinst qemu-x86 qemu-tools |
There was a problem hiding this comment.
Could you please clarify why the qemu-x86 qemu-tools packages has to be added? Is the isotovideo going to use it?
There was a problem hiding this comment.
yes. os-autoinst supports multiple backends. qemu is just one of them so this is why I built multiple variants in https://build.opensuse.org/project/show/home:okurz:container, e.g. isotovideo-qemu, isotovideo-qemu-kvm, isotovideo-qemu-x86, see the build tag and the filename. Do you think we can better specify that specific variant elsewhere or differently? We could add specific subpackages to https://github.com/os-autoinst/os-autoinst/blob/master/dist/rpm/os-autoinst.spec#L92 and install these.
There was a problem hiding this comment.
Thanks for the explanation. Could it be possible to do it architecture independent as we did on https://github.com/os-autoinst/openQA/blob/6a2b837473d592e55b6c49e7a0a18a9d53270b59/docker/worker/Dockerfile#L12?
There was a problem hiding this comment.
I see the current PR as ready to be merged but based on your comment I have also provided #1573 now with an alternative approach. They don't conflict and we can also change Dockerfile.qemu-x86 later if the other packages are provided.
There was a problem hiding this comment.
Thanks, I think I'll approve both 👍
|
@Martchus can you approve? |
okurz
deleted the
feature/ci_standalone_isotovideo_only_container_poo77905
branch
I had
https://build.opensuse.org/package/view_file/home:okurz:container/isotovideo/Dockerfile
since about a year. This commit pushes that upstream to os-autoinst and
adapts to work in more general CI pipelines in a limited way, e.g. also
github actions where no nested virt and hence no KVM is available. With
this commit we can publish the container and image as an easier entry
point for users and also to be used within CI pipelines of other
projects.
The same Dockerfile configuration was used
in
https://build.opensuse.org/package/view_file/home:okurz:container/isotovideo-qemu-x86/Dockerfile?expand=1
which in turn was used in
os-autoinst/os-autoinst-distri-example#4
to show how isotovideo can be run as part of a CI pipeline using github
actions.
Related progress issue: https://progress.opensuse.org/issues/77905