Add coverage for unimplemented methods #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix subroutine signatures for some of the methods. Related: https://progress.opensuse.org/issues/104499
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
+ Coverage 67.77% 67.94% +0.17%
==========================================
Files 64 64
Lines 6957 6960 +3
==========================================
+ Hits 4715 4729 +14
+ Misses 2242 2231 -11
Continue to review full report at Codecov.
|
kraih
approved these changes
Dec 29, 2021
okurz
reviewed
Jan 3, 2022
Comment on lines
+70
to
+72
| eval { $dummy->$m(@args) }; | ||
| my $err = $@; | ||
| like $err, qr{backend method '$m' not implemented for class 'dummy'}, "notimplemented() works for '\$self->$m(@args)'"; |
There was a problem hiding this comment.
I guess we could use https://metacpan.org/pod/Test::Fatal here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix subroutine signatures for some of the methods.
Related: https://progress.opensuse.org/issues/104499