testapi: Save time in "wait_screen_change" with "no_wait" option as well #2109
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
Codecov Report
@@ Coverage Diff @@
## master #2109 +/- ##
=======================================
Coverage 81.83% 81.83%
=======================================
Files 73 73
Lines 7428 7428
=======================================
Hits 6079 6079
Misses 1349 1349
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…aiting too long Needs os-autoinst/os-autoinst#2109 Related progress issue: https://progress.opensuse.org/issues/109737
|
Trying it out with Created job #2453487: opensuse-Tumbleweed-DVD-x86_64-Build20220704-extra_tests_gnome@64bit -> https://openqa.opensuse.org/t2453487 |
|
https://openqa.opensuse.org/t2453487 doesn't seem to have a reduced waiting time. So something might still be missing. |
This commit also checks for the "no_wait" option in "wait_screen_change" same as we already do in other cases like "check_screen/assert_screen" and "wait_still_screen". Related progress issue: https://progress.opensuse.org/issues/109737
"do_wait" was made ineffective with 3c7ae92 about three years ago and can be removed.
This allows configuring wait_screen_change calls, in particular "no_wait". Related progress issue: https://progress.opensuse.org/issues/109737
okurz
force-pushed
the
feature/no_wait_on_wait_screen_change
branch
from
c6e86b9
to
3c61e26
Compare
|
Updated with a further change to pass "%args" to wait_screen_change calls so that the "no_wait" parameter is also passed on. Not yet tested in production but with extended unit tests. |
…aiting too long Needs os-autoinst/os-autoinst#2109 Related progress issue: https://progress.opensuse.org/issues/109737
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
obsoleted by #2164 |
This commit also checks for the "no_wait" option in "wait_screen_change"
same as we already do in other cases like "check_screen/assert_screen"
and "wait_still_screen".
Hotpatched w7 with:
Triggered verification run with:
Created job #2453477: opensuse-Tumbleweed-DVD-x86_64-Build20220704-extra_tests_gnome@64bit -> https://openqa.opensuse.org/t2453477
Related progress issue: https://progress.opensuse.org/issues/109737