Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move check_asserted_screen into CommandHandler #2196

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

kalikiana
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #2196 (4904dcc) into master (62acb88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2196   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files         157      157           
  Lines       15192    15201    +9     
=======================================
+ Hits        14000    14009    +9     
  Misses       1192     1192           
Impacted Files Coverage Δ
OpenQA/Isotovideo/CommandHandler.pm 100.00% <100.00%> (ø)
isotovideo 90.39% <100.00%> (-0.98%) ⬇️
t/19-isotovideo-command-processing.t 97.68% <100.00%> (+0.04%) ⬆️
t/data/tests/bar/baz.pm
t/data/tests/foo.pm 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

OpenQA/Isotovideo/CommandHandler.pm Outdated Show resolved Hide resolved
OpenQA/Isotovideo/CommandHandler.pm Outdated Show resolved Hide resolved
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have only a small suggestion to reduce code duplication.

OpenQA/Isotovideo/CommandHandler.pm Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 7a0df62 into os-autoinst:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants