New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move loop into CommandHandler #2200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2200 +/- ##
==========================================
+ Coverage 92.15% 92.20% +0.04%
==========================================
Files 157 157
Lines 15201 15228 +27
==========================================
+ Hits 14009 14041 +32
+ Misses 1192 1187 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the events looks generally good (especially considering events are already used here anyways).
61e31a1
to
a12cb41
Compare
Yeah, that was a good idea. Now I'm only unsure about my test for the rpc. Dropping fileno gets rid of warnings from the log message. Maybe I need to mock all file handles afterall. |
a12cb41
to
b770a7c
Compare
84e7d7d
to
41aa871
Compare
This pull request is now in conflicts. Could you fix it? 🙏 |
41aa871
to
abaa297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov/project/fully_covered failed
abaa297
to
8290a8f
Compare
Now patch coverage :) |
Well, if you consider it useful I'll mark it as uncoverable. I don't fully understand why it shows up even though isotovideo is already exempt... |
8290a8f
to
2b37551
Compare
See: https://progress.opensuse.org/issues/81899
Note: Requires #2196