Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move loop into CommandHandler #2200

Merged
merged 1 commit into from Nov 15, 2022
Merged

Conversation

kalikiana
Copy link
Member

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #2200 (8290a8f) into master (7a0df62) will increase coverage by 0.04%.
The diff coverage is 92.06%.

❗ Current head 8290a8f differs from pull request most recent head 2b37551. Consider uploading reports for the commit 2b37551 to get more accurate results

@@            Coverage Diff             @@
##           master    #2200      +/-   ##
==========================================
+ Coverage   92.15%   92.20%   +0.04%     
==========================================
  Files         157      157              
  Lines       15201    15228      +27     
==========================================
+ Hits        14009    14041      +32     
+ Misses       1192     1187       -5     
Impacted Files Coverage Δ
isotovideo 92.76% <50.00%> (+2.36%) ⬆️
OpenQA/Isotovideo/CommandHandler.pm 100.00% <100.00%> (ø)
t/19-isotovideo-command-processing.t 97.91% <100.00%> (+0.22%) ⬆️
testapi.pm 74.74% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of the events looks generally good (especially considering events are already used here anyways).

isotovideo Show resolved Hide resolved
@kalikiana kalikiana force-pushed the cmd_h_loop branch 2 times, most recently from 61e31a1 to a12cb41 Compare November 9, 2022 15:43
@kalikiana
Copy link
Member Author

The use of the events looks generally good (especially considering events are already used here anyways).

Yeah, that was a good idea.

Now I'm only unsure about my test for the rpc. Dropping fileno gets rid of warnings from the log message. Maybe I need to mock all file handles afterall.

isotovideo Show resolved Hide resolved
OpenQA/Isotovideo/CommandHandler.pm Outdated Show resolved Hide resolved
OpenQA/Isotovideo/CommandHandler.pm Outdated Show resolved Hide resolved
@kalikiana kalikiana force-pushed the cmd_h_loop branch 2 times, most recently from 84e7d7d to 41aa871 Compare November 10, 2022 18:30
@kalikiana kalikiana marked this pull request as ready for review November 10, 2022 18:30
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

This pull request is now in conflicts. Could you fix it? 🙏

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov/project/fully_covered failed

@okurz
Copy link
Member

okurz commented Nov 15, 2022

Now patch coverage :)

@kalikiana
Copy link
Member Author

kalikiana commented Nov 15, 2022

Now patch coverage :)

Well, if you consider it useful I'll mark it as uncoverable. I don't fully understand why it shows up even though isotovideo is already exempt...

@mergify mergify bot merged commit 3ec4604 into os-autoinst:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants