New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for warnings in isotovideo test #2211
Conversation
And remove the misleading and unused output handling. See: https://progress.opensuse.org/issues/120786
89b0338
to
7accf74
Compare
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 157 157
Lines 15218 15218
=======================================
Hits 14042 14042
Misses 1176 1176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment. I don't see how this helps
It helps by revealing the information we used to understand the problem. As for CI I opened #2213. |
The description still says that #2206 would have failed with this. |
I re-phrased it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why removing $output as a return value from isotovideo()
would be necessary but ok...
And remove the misleading and unused output handling.
See: https://progress.opensuse.org/issues/120786
Note: This would have shown a clear error message when failing tests in #2206. It doesn't address the problem of CI behaving differently.