Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further extend basetest.pm code coverage #2215

Conversation

r-richardson
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #2215 (9e2d22c) into master (d394078) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2215      +/-   ##
==========================================
+ Coverage   92.60%   92.68%   +0.07%     
==========================================
  Files         157      157              
  Lines       15341    15367      +26     
==========================================
+ Hits        14207    14243      +36     
+ Misses       1134     1124      -10     
Impacted Files Coverage Δ
basetest.pm 99.07% <100.00%> (+3.06%) ⬆️
t/17-basetest.t 99.23% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@r-richardson r-richardson force-pushed the 94952_extend_os_autoinst_basetest_experimental branch 3 times, most recently from 470b2c2 to 0673d17 Compare November 23, 2022 10:11
t/17-basetest.t Outdated Show resolved Hide resolved
@r-richardson r-richardson force-pushed the 94952_extend_os_autoinst_basetest_experimental branch 4 times, most recently from 7e651fa to 84436b8 Compare November 23, 2022 16:33
@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

This pull request is now in conflicts. Could you fix it? 🙏

@r-richardson r-richardson changed the title Futher extend basetest.pm code coverage (draft/experimental) Further extend basetest.pm code coverage (draft/experimental) Nov 25, 2022
@r-richardson r-richardson force-pushed the 94952_extend_os_autoinst_basetest_experimental branch from 84436b8 to 8f93400 Compare November 25, 2022 13:57
@r-richardson r-richardson changed the title Further extend basetest.pm code coverage (draft/experimental) Further extend basetest.pm code coverage Nov 25, 2022
@r-richardson r-richardson marked this pull request as ready for review November 25, 2022 13:58
Copy link
Member

@kalikiana kalikiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now I'd say; the CI failure is unrelated

@Martchus
Copy link
Contributor

Yes, the CI failure also happened on my PR. It is even before tests are starting (likely related to the package caching).

@r-richardson
Copy link
Contributor Author

ok, so i can just manually merge now ?

@kalikiana
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 25, 2022

rebase

✅ Branch has been successfully rebased

@kraih kraih force-pushed the 94952_extend_os_autoinst_basetest_experimental branch from 8f93400 to 9e2d22c Compare November 25, 2022 16:49
@mergify mergify bot merged commit d36887c into os-autoinst:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants