Merge pull request #303 from perlpunk/no-git-url

Do not create investigation jobs with broken CASEDIR

openqa-investigate

@@ -54,7 +54,13 @@ clone() {
         vars_json=$(fetch-vars-json "$origin")
         testgiturl=$(echo "$vars_json" | runjq -r '.TEST_GIT_URL')
         casedir=$(echo "$clone_job_data" | runjq -r '.job.settings.CASEDIR') || return $?
-        [[ $testgiturl != null ]] && casedir=$testgiturl
+        if [[ $testgiturl != null ]]; then
+            if [[ ! $testgiturl =~ ^https?://[^[:space:]]+$ ]]; then
+                warn "Can not clone refspec of job $origin with unknown/invalid git url TEST_GIT_URL='$testgiturl'"
+                return 0
+            fi
+            casedir=$testgiturl
+        fi
         [[ $casedir == null ]] && casedir=''
         repo=${casedir:-'https://github.com/os-autoinst/os-autoinst-distri-opensuse.git'}
         clone_settings+=("CASEDIR=${repo%#*}#${refspec}")

test/02-investigate.t

@@ -3,7 +3,7 @@
 source test/init
 bpan:source bashplus +err +fs +sym
 
-plan tests 85
+plan tests 87
 
 host=localhost
 url=https://localhost
@@ -21,6 +21,8 @@ fetch-vars-json() {
     local tid=$1
     if [[ $tid -eq 10020 ]]; then
         echo '{"TEST_GIT_URL": "https://github.com/os-autoinst/os-autoinst-distri-openQA.git"}'
+    elif [[ $tid -eq 10026 ]]; then
+        echo '{"TEST_GIT_URL": "UNKNOWN (origin remote not found)"}'
     elif [[ $tid -eq 10022 ]]; then
         echo '{"WORKER_CLASS": "foo,duh,bar"}'
     else
@@ -232,6 +234,10 @@ try clone 10023 10024 foo refspec
 is "$rc" 0 "Successful clone"
 like "$got" 'CASEDIR=.*/os-autoinst-distri-opensuse.git#refspec' "job is cloned and it uses default CASEDIR"
 
+try clone 10026 10024 foo refspec
+is "$rc" 0 "Successful clone"
+like "$got" 'Can not clone refspec' "job with non-git TEST_GIT_URL is not cloned"
+
 try clone 10020 10024 foo refspec
 is "$rc" 0 "Successful clone"
 like "$got" 'CASEDIR=.*/os-autoinst-distri-openQA.git#refspec' "job is cloned with sets CASEDIR from TEST_GIT_URL"