Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wrapper scripts for batch processing #201

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Jan 19, 2023

Make openqa-label-known-issues and openqa-investigate take a single url

and provide wrapper scripts {openqa-label-known-issues,openqa-investigate}-multi for
batch operations.

This makesthe scripts easier to use and test.

We can call a single command for a single url that we pass as a
parameter.
Having to pipe the url makes it harder to use.
Also with a command for a single url we can easier write tests for
this command.

Related issue: https://progress.opensuse.org/issues/98862

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

and provide a wrapper script openqa-label-known-issues-multi for
batch operations.

This makes openqa-label-known-issues easier to use and test.

We can call a single command for a single url that we pass as a
parameter.
Having to pipe the url makes it harder to use.
Also with a command for a single url we can easier write tests for
this command.

Related issue: https://progress.opensuse.org/issues/98862
See previous commit for reasons
@perlpunk perlpunk marked this pull request as ready for review January 20, 2023 11:40
@mergify mergify bot merged commit a63293c into os-autoinst:master Jan 20, 2023
@perlpunk perlpunk deleted the multi-wrapper branch January 20, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants