Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dm updates 3 #1567

Merged
merged 4 commits into from
May 4, 2024
Merged

Dm updates 3 #1567

merged 4 commits into from
May 4, 2024

Conversation

manadher
Copy link
Contributor

@manadher manadher commented May 4, 2024

Motivate of the pull request

  • implementing
    set_io_bank
    set_logic_location
    set_phy_address
    get_io_bank
    get_phy_address
    get_logic_location

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 132 lines in your changes are missing coverage. Please review.

Project coverage is 14.45%. Comparing base (c80e89d) to head (934d23d).
Report is 2 commits behind head on main.

Files Patch % Lines
src/DeviceModeling/device_modeler.h 0.00% 118 Missing ⚠️
src/DeviceModeling/DeviceModeling.cpp 0.00% 12 Missing ⚠️
src/DeviceModeling/device_instance.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   14.49%   14.45%   -0.05%     
==========================================
  Files         476      476              
  Lines       61685    61871     +186     
  Branches    24788    24910     +122     
==========================================
+ Hits         8939     8941       +2     
- Misses      51668    51846     +178     
- Partials     1078     1084       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alaindargelas alaindargelas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manadher please point me to the try-catch section that will treat the exception, where is it?

@alaindargelas alaindargelas merged commit 6aa5bd7 into main May 4, 2024
33 of 35 checks passed
@alaindargelas alaindargelas deleted the DM_UPDATES_3 branch May 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants