Foreach in the correct way on database function

osCommerce · Aug 17, 2011 · b26f367 · b26f367
1 parent 8e40f3a
commit b26f367
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/catalog/admin/includes/functions/database.php b/catalog/admin/includes/functions/database.php
@@ -59,8 +59,7 @@ function tep_db_perform($table, $data, $action = 'insert', $parameters = '', $li
         $query .= $columns . ', ';
       }
       $query = substr($query, 0, -2) . ') values (';
-      reset($data);
-      while (list(, $value) = each($data)) {
+      foreach($data as $value) {
         switch ((string)$value) {
           case 'now()':
             $query .= 'now(), ';

diff --git a/catalog/includes/functions/database.php b/catalog/includes/functions/database.php
@@ -55,12 +55,12 @@ function tep_db_perform($table, $data, $action = 'insert', $parameters = '', $li
     reset($data);
     if ($action == 'insert') {
       $query = 'insert into ' . $table . ' (';
+
       while (list($columns, ) = each($data)) {
         $query .= $columns . ', ';
       }
       $query = substr($query, 0, -2) . ') values (';
-      reset($data);
-      while (list(, $value) = each($data)) {
+     foreach($data as $value) {
         switch ((string)$value) {
           case 'now()':
             $query .= 'now(), ';