Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table "ost_ticket_thread" -> field "title" has wrong encoding #718

Closed
PawelBaczkiewicz opened this issue Sep 12, 2013 · 4 comments
Closed

table "ost_ticket_thread" -> field "title" has wrong encoding #718

PawelBaczkiewicz opened this issue Sep 12, 2013 · 4 comments
Labels
duplicate

Comments

@PawelBaczkiewicz
Copy link

Hi,

Since I've upgraded my osticket version I noticed field "title" is incorrectly encoded in table "ost_ticket_thread".
Value is also displayed incorrectly.

Example in Polish language: "wówczas".

"ó" is translated into: ó. This value is also displayed in osticket threads in staff panel. If you create a ticket putting "Subject" as "wówczas", the ticket is created with correct title "wówczas", but thread title is converted into "wówczas".

Would be nice to have fix that.
@greezybacon
Copy link
Contributor

Thanks for bringing this up again. It's a duplicate of #567. I agree it needs to be addressed pronto

@PawelBaczkiewicz
Copy link
Author

Sorry for duplicating :/ I hope it will be fixed soon.
Thanks in advance.

greezybacon pushed a commit to greezybacon/osTicket-1.7 that referenced this issue Sep 13, 2013
Avoid double-encoding thread titles
fb78bcb 
Fixes osTicket#567, osTicket#718
greezybacon pushed a commit to greezybacon/osTicket-1.7 that referenced this issue Sep 13, 2013
Avoid double-encoding thread titles
bd68088 
This is safe now, because the title is appropriately encoded in
class.thread.php/ThreadEntry::create()

Fixes osTicket#567, osTicket#718
@greezybacon greezybacon mentioned this issue Sep 13, 2013
Merged
@greezybacon
Copy link
Contributor

I've mocked it up in #720. I would appreciate your feedback if it correctly addresses the issue

@greezybacon
Copy link
Contributor

Thanks for reporting this! It was merged and released into 1.7.1.3

alpianon pushed a commit to alpianon/osTicket-1.7-ClientAuth-CCemails that referenced this issue Nov 20, 2013
Avoid double-encoding thread titles
cece7a0 
This is safe now, because the title is appropriately encoded in
class.thread.php/ThreadEntry::create()

Fixes osTicket#567, osTicket#718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greezybacon @PawelBaczkiewicz