Fix potential XSS vulnerability on user's name #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ? array_map(array('Format','htmlencode'), $var) | ||
| : htmlentities($var, $flags, 'UTF-8'); | ||
| ? array_map(array('Format', 'htmlencode'), $var) | ||
| : htmlentities( (string) $var, $flags, 'UTF-8'); |
There was a problem hiding this comment.
If we do
: htmlentities( (string) $var, $flags, 'UTF-8', false);(add $double_encode = false to the argument list), then I think we can go ahead and sanitize the user name when saving to the database
Names parsed from incoming emails are stored in the database as is. This pull request addresses potential XSS vulnerability due to improper display of unsanitized names. Going forward names will be scrubbed on create.
|
Updated |
greezybacon
added a commit
that referenced
this pull request
Jul 18, 2014
Fix potential XSS vulnerability on user's name Reviewed-By: Jared Hancock <jared@osticket.com>
protich
pushed a commit
to protich/osTicket
that referenced
this pull request
Jul 21, 2014
Fix potential XSS vulnerability on user's name Reviewed-By: Jared Hancock <jared@osticket.com>
protich
pushed a commit
to protich/osTicket
that referenced
this pull request
Jul 29, 2014
Fix potential XSS vulnerability on user's name Reviewed-By: Jared Hancock <jared@osticket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names parsed from incoming emails are stored in the database as is. This pull request addresses potential XSS vulnerability due to improper storage and display of unsanitized names.